Simplify clone methods by using generic type parameter

Author: bkoelman

src/JsonApiDotNetCore.OpenApi/JsonApiActionDescriptorCollectionProvider.cs

@@ -13,8 +13,10 @@ namespace JsonApiDotNetCore.OpenApi;
 
 /// <summary>
 /// Adds JsonApiDotNetCore metadata to <see cref="ControllerActionDescriptor" />s if available. This translates to updating response types in
-/// <see cref="ProducesResponseTypeAttribute" /> and performing an expansion for secondary and relationship endpoints (eg
-/// /article/{id}/{relationshipName} -> /article/{id}/author, /article/{id}/revisions, etc).
+/// <see cref="ProducesResponseTypeAttribute" /> and performing an expansion for secondary and relationship endpoints. For example:
+/// <code><![CDATA[
+/// /article/{id}/{relationshipName} -> /article/{id}/author, /article/{id}/revisions, etc.
+/// ]]></code>
 /// </summary>
 internal sealed class JsonApiActionDescriptorCollectionProvider : IActionDescriptorCollectionProvider
 {
@@ -163,30 +165,16 @@ private static void UpdateBodyParameterDescriptor(ActionDescriptor endpoint, Typ
 
     private static ActionDescriptor Clone(ActionDescriptor descriptor)
     {
-        var clone = (ActionDescriptor)descriptor.MemberwiseClone();
-
-        clone.AttributeRouteInfo = (AttributeRouteInfo)descriptor.AttributeRouteInfo!.MemberwiseClone();
-
-        clone.FilterDescriptors = new List<FilterDescriptor>();
-
-        foreach (FilterDescriptor filter in descriptor.FilterDescriptors)
-        {
-            clone.FilterDescriptors.Add(Clone(filter));
-        }
-
-        clone.Parameters = new List<ParameterDescriptor>();
-
-        foreach (ParameterDescriptor parameter in descriptor.Parameters)
-        {
-            clone.Parameters.Add((ParameterDescriptor)parameter.MemberwiseClone());
-        }
-
+        ActionDescriptor clone = descriptor.MemberwiseClone();
+        clone.AttributeRouteInfo = descriptor.AttributeRouteInfo!.MemberwiseClone();
+        clone.FilterDescriptors = descriptor.FilterDescriptors.Select(Clone).ToList();
+        clone.Parameters = descriptor.Parameters.Select(parameter => parameter.MemberwiseClone()).ToList();
         return clone;
     }
 
     private static FilterDescriptor Clone(FilterDescriptor descriptor)
     {
-        var clone = (IFilterMetadata)descriptor.Filter.MemberwiseClone();
+        IFilterMetadata clone = descriptor.Filter.MemberwiseClone();
 
         return new FilterDescriptor(clone, descriptor.Scope)
         {

src/JsonApiDotNetCore.OpenApi/ObjectExtensions.cs

@@ -8,10 +8,11 @@ internal static class ObjectExtensions
         new(() => typeof(object).GetMethod(nameof(MemberwiseClone), BindingFlags.Instance | BindingFlags.NonPublic)!,
             LazyThreadSafetyMode.ExecutionAndPublication);
 
-    public static object MemberwiseClone(this object source)
+    public static T MemberwiseClone<T>(this T source)
+        where T : class
     {
         ArgumentGuard.NotNull(source);
 
-        return MemberwiseCloneMethod.Value.Invoke(source, null)!;
+        return (T)MemberwiseCloneMethod.Value.Invoke(source, null)!;
     }
 }