test(*): fix test that are dependent on some items being defined

No tests should be dependent upon any items existing in the context previously

Author: jaredcnance

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DocumentTests/PagingTests.cs

@@ -48,8 +48,15 @@ public async Task Server_IncludesPagination_Links()
         {
             // arrange
             var pageSize = 5;
-            var numberOfTodoItems = _context.TodoItems.Count();
-            var numberOfPages = (int)Math.Ceiling(decimal.Divide(numberOfTodoItems, pageSize));
+            const int minimumNumberOfRecords = 11;
+            _context.TodoItems.RemoveRange(_context.TodoItems);
+
+            for(var i=0; i < minimumNumberOfRecords; i++)
+                _context.TodoItems.Add(_todoItemFaker.Generate());
+
+            await _context.SaveChangesAsync();
+
+            var numberOfPages = (int)Math.Ceiling(decimal.Divide(minimumNumberOfRecords, pageSize));
             var startPageNumber = 2;
 
             var builder = new WebHostBuilder()

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DocumentTests/Relationships.cs

@@ -11,6 +11,8 @@
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCoreExample.Data;
 using System.Linq;
+using Bogus;
+using JsonApiDotNetCoreExample.Models;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec.DocumentTests
 {
@@ -19,10 +21,15 @@ public class Relationships
     {
         private DocsFixture<Startup, JsonDocWriter> _fixture;
         private AppDbContext _context;
+        private Faker<TodoItem> _todoItemFaker;
+
         public Relationships(DocsFixture<Startup, JsonDocWriter> fixture)
         {
             _fixture = fixture;
             _context = fixture.GetService<AppDbContext>();
+             _todoItemFaker = new Faker<TodoItem>()
+                .RuleFor(t => t.Description, f => f.Lorem.Sentence())
+                .RuleFor(t => t.Ordinal, f => f.Random.Number());
         }
 
         [Fact]
@@ -31,18 +38,22 @@ public async Task Correct_RelationshipObjects_For_ManyToOne_Relationships()
             // arrange
             var builder = new WebHostBuilder()
                 .UseStartup<Startup>();
+            
+            var todoItem = _todoItemFaker.Generate();
+            _context.TodoItems.Add(todoItem);
+            await _context.SaveChangesAsync();
 
             var httpMethod = new HttpMethod("GET");
-            var route = $"/api/v1/todo-items";
+            var route = $"/api/v1/todo-items/{todoItem.Id}";
 
             var server = new TestServer(builder);
             var client = server.CreateClient();
             var request = new HttpRequestMessage(httpMethod, route);
 
             // act
             var response = await client.SendAsync(request);
-            var documents = JsonConvert.DeserializeObject<Documents>(await response.Content.ReadAsStringAsync());
-            var data = documents.Data[0];
+            var document = JsonConvert.DeserializeObject<Document>(await response.Content.ReadAsStringAsync());
+            var data = document.Data;
             var expectedOwnerSelfLink = $"http://localhost/api/v1/todo-items/{data.Id}/relationships/owner";
             var expectedOwnerRelatedLink = $"http://localhost/api/v1/todo-items/{data.Id}/owner";
 
@@ -56,13 +67,15 @@ public async Task Correct_RelationshipObjects_For_ManyToOne_Relationships()
         public async Task Correct_RelationshipObjects_For_ManyToOne_Relationships_ById()
         {
             // arrange
-            var todoItemId = _context.TodoItems.Last().Id;
-
             var builder = new WebHostBuilder()
                 .UseStartup<Startup>();
+            
+            var todoItem = _todoItemFaker.Generate();
+            _context.TodoItems.Add(todoItem);
+            await _context.SaveChangesAsync();
 
             var httpMethod = new HttpMethod("GET");
-            var route = $"/api/v1/todo-items/{todoItemId}";
+            var route = $"/api/v1/todo-items/{todoItem.Id}";
 
             var server = new TestServer(builder);
             var client = server.CreateClient();
@@ -72,8 +85,8 @@ public async Task Correct_RelationshipObjects_For_ManyToOne_Relationships_ById()
             var response = await client.SendAsync(request);
             var responseString = await response.Content.ReadAsStringAsync();
             var data = JsonConvert.DeserializeObject<Document>(responseString).Data;
-            var expectedOwnerSelfLink = $"http://localhost/api/v1/todo-items/{todoItemId}/relationships/owner";
-            var expectedOwnerRelatedLink = $"http://localhost/api/v1/todo-items/{todoItemId}/owner";
+            var expectedOwnerSelfLink = $"http://localhost/api/v1/todo-items/{todoItem.Id}/relationships/owner";
+            var expectedOwnerRelatedLink = $"http://localhost/api/v1/todo-items/{todoItem.Id}/owner";
 
             // assert
             Assert.Equal(HttpStatusCode.OK, response.StatusCode);