test(OperationsProcessor): performs pointer substitution

Author: jaredcnance

src/JsonApiDotNetCore/Services/Operations/IOperationsProcessor.cs

@@ -19,6 +19,7 @@ public OperationsProcessor(IOperationProcessorResolver processorResolver)
         {
             _processorResolver = processorResolver;
         }
+        
         public async Task<List<Operation>> ProcessAsync(List<Operation> inputOps)
         {
             var outputOps = new List<Operation>();
@@ -31,15 +32,14 @@ public async Task<List<Operation>> ProcessAsync(List<Operation> inputOps)
                 var replacer = new DocumentDataPointerReplacement<OperationsPointer, Operation>(op.DataObject);
                 replacer.ReplacePointers(outputOps);
 
-                /// 
                 var processor = _processorResolver.LocateCreateService(op);
                 var resultOp = await processor.ProcessAsync(op);
-                outputOps.Add(resultOp);
-            }
-            for(var i=0; i < inputOps.Count; i++)
-            {
 
+                if(resultOp != null)
+                    outputOps.Add(resultOp);
             }
+
+            return outputOps;
         }
     }
 }

src/JsonApiDotNetCore/Services/Operations/OperationProcessorResolver.cs

@@ -1,5 +1,4 @@
 using System.Collections.Concurrent;
-using JsonApiDotNetCore.Internal;
 using JsonApiDotNetCore.Internal.Generics;
 using JsonApiDotNetCore.Models.Operations;
 
@@ -33,7 +32,7 @@ public IOpProcessor LocateCreateService(Operation operation)
             if (_cachedProcessors.TryGetValue(resource, out IOpProcessor cachedProcessor))
                 return cachedProcessor;
 
-            var contextEntity = _context.ContextGraph.GetContextEntity();
+            var contextEntity = _context.ContextGraph.GetContextEntity(resource);
             var processor = _processorFactory.GetProcessor<IOpProcessor>(contextEntity.EntityType, contextEntity.IdentityType);
 
             _cachedProcessors[resource] = processor;

test/UnitTests/Services/Operations/OperationsProcessorTests.cs

@@ -0,0 +1,94 @@
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using JsonApiDotNetCore.Models.Operations;
+using JsonApiDotNetCore.Services.Operations;
+using Moq;
+using Newtonsoft.Json;
+using Xunit;
+
+namespace UnitTests.Services
+{
+    public class OperationsProcessorTests
+    {
+        private readonly Mock<IOperationProcessorResolver> _resolverMock;
+
+        public OperationsProcessorTests()
+        {
+            _resolverMock = new Mock<IOperationProcessorResolver>();
+        }
+
+        [Fact]
+        public async Task ProcessAsync_Performs_Pointer_ReplacementAsync()
+        {
+            // arrange
+            var request = @"[
+                {
+                    ""op"": ""add"",
+                    ""data"": {
+                        ""type"": ""authors"",
+                        ""attributes"": {
+                            ""name"": ""dgeb""
+                        }
+                    }
+                }, {
+                    ""op"": ""add"",
+                    ""data"": {
+                        ""type"": ""articles"",
+                        ""attributes"": {
+                            ""title"": ""JSON API paints my bikeshed!""
+                        },
+                        ""relationships"": {
+                            ""author"": {
+                                ""data"": {
+                                    ""type"": ""authors"",
+                                    ""id"": { ""pointer"": ""/operations/0/data/id"" }
+                                }
+                            }
+                        }
+                    }
+                }
+            ]";
+
+            var op1Result = @"{
+                ""links"": {
+                    ""self"": ""http://example.com/authors/9""
+                },
+                ""data"": {
+                    ""type"": ""authors"",
+                    ""id"": ""9"",
+                    ""attributes"": {
+                        ""name"": ""dgeb""
+                    }
+                }
+            }";
+                
+            var operations = JsonConvert.DeserializeObject<List<Operation>>(request);
+            var addOperationResult = JsonConvert.DeserializeObject<Operation>(op1Result);
+
+            var opProcessorMock = new Mock<IOpProcessor>();
+            opProcessorMock.Setup(m => m.ProcessAsync(It.Is<Operation>(op => op.DataObject.Type.ToString() == "authors")))
+                .ReturnsAsync(addOperationResult);
+            
+            _resolverMock.Setup(m => m.LocateCreateService(It.IsAny<Operation>()))
+                .Returns(opProcessorMock.Object);
+            
+            _resolverMock.Setup(m => m.LocateCreateService((It.IsAny<Operation>())))
+                .Returns(opProcessorMock.Object);
+
+            var operationsProcessor = new OperationsProcessor(_resolverMock.Object);
+
+            // act
+            var results = await operationsProcessor.ProcessAsync(operations);
+
+            // assert
+            opProcessorMock.Verify(
+                m => m.ProcessAsync(
+                    It.Is<Operation>(o => 
+                        o.DataObject.Type.ToString() == "articles"
+                        && o.DataObject.Relationships["author"].SingleData["id"].ToString() == "9"
+                    )
+                )
+            );
+        }
+    }
+}