Review feedback: rename method

Bart Koelman · Bart Koelman · commit c25c6c8b2811 · 2020-08-14T16:26:06.000+02:00
diff --git a/src/JsonApiDotNetCore/Internal/Queries/Parsing/QueryTokenizer.cs b/src/JsonApiDotNetCore/Internal/Queries/Parsing/QueryTokenizer.cs
@@ -54,7 +54,7 @@ public IEnumerable<Token> EnumerateTokens()
 
                         _isInQuotedSection = false;
 
-                        Token literalToken = FlushTextBuffer(true);
+                        Token literalToken = ProduceTokenFromTextBuffer(true);
                         yield return literalToken;
                     }
                     else
@@ -73,7 +73,7 @@ public IEnumerable<Token> EnumerateTokens()
 
                     if (singleCharacterTokenKind != null && !IsMinusInsideText(singleCharacterTokenKind.Value))
                     {
-                        Token identifierToken = FlushTextBuffer(false);
+                        Token identifierToken = ProduceTokenFromTextBuffer(false);
 
                         if (identifierToken != null)
                         {
@@ -101,7 +101,7 @@ public IEnumerable<Token> EnumerateTokens()
                 throw new QueryParseException("' expected.");
             }
 
-            Token lastToken = FlushTextBuffer(false);
+            Token lastToken = ProduceTokenFromTextBuffer(false);
 
             if (lastToken != null)
             {
@@ -124,7 +124,7 @@ private bool IsMinusInsideText(TokenKind kind)
             return SingleCharacterToTokenKinds.ContainsKey(ch) ? (TokenKind?)SingleCharacterToTokenKinds[ch] : null;
         }
 
-        private Token FlushTextBuffer(bool isQuotedText)
+        private Token ProduceTokenFromTextBuffer(bool isQuotedText)
         {
             if (isQuotedText || _textBuffer.Length > 0)
             {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public IEnumerable<Token> EnumerateTokens()`
`54`	`54`
`55`	`55`	`_isInQuotedSection = false;`
`56`	`56`
`57`		`- Token literalToken = FlushTextBuffer(true);`
	`57`	`+ Token literalToken = ProduceTokenFromTextBuffer(true);`
`58`	`58`	`yield return literalToken;`
`59`	`59`	`}`
`60`	`60`	`else`
`@@ -73,7 +73,7 @@ public IEnumerable<Token> EnumerateTokens()`
`73`	`73`
`74`	`74`	`if (singleCharacterTokenKind != null && !IsMinusInsideText(singleCharacterTokenKind.Value))`
`75`	`75`	`{`
`76`		`- Token identifierToken = FlushTextBuffer(false);`
	`76`	`+ Token identifierToken = ProduceTokenFromTextBuffer(false);`
`77`	`77`
`78`	`78`	`if (identifierToken != null)`
`79`	`79`	`{`
`@@ -101,7 +101,7 @@ public IEnumerable<Token> EnumerateTokens()`
`101`	`101`	`throw new QueryParseException("' expected.");`
`102`	`102`	`}`
`103`	`103`
`104`		`- Token lastToken = FlushTextBuffer(false);`
	`104`	`+ Token lastToken = ProduceTokenFromTextBuffer(false);`
`105`	`105`
`106`	`106`	`if (lastToken != null)`
`107`	`107`	`{`
`@@ -124,7 +124,7 @@ private bool IsMinusInsideText(TokenKind kind)`
`124`	`124`	`return SingleCharacterToTokenKinds.ContainsKey(ch) ? (TokenKind?)SingleCharacterToTokenKinds[ch] : null;`
`125`	`125`	`}`
`126`	`126`
`127`		`- private Token FlushTextBuffer(bool isQuotedText)`
	`127`	`+ private Token ProduceTokenFromTextBuffer(bool isQuotedText)`
`128`	`128`	`{`
`129`	`129`	`if (isQuotedText \|\| _textBuffer.Length > 0)`
`130`	`130`	`{`