fix(inputFormatters): needed FromBody param attribute

Author: jaredcnance

.vscode/tasks.json

@@ -1,20 +1,20 @@
 {
-    // See https://go.microsoft.com/fwlink/?LinkId=733558
-    // for the documentation about the tasks.json format
-    "version": "0.1.0",
-    "command": "dotnet",
-    "isShellCommand": true,
-    "args": [],
-    "options": {
-      "cwd": "${workspaceRoot}/src/Examples/JsonApiDotNetCoreExample"
-    },
-    "tasks": [
-        {
-            "taskName": "build",
-            "args": [ ],
-            "isBuildCommand": true,
-            "showOutput": "silent",
-            "problemMatcher": "$msCompile"
-        }
-    ]
-}
+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format
+  "version": "0.1.0",
+  "command": "dotnet",
+  "isShellCommand": true,
+  "args": [],
+  "options": {
+    "cwd": "${workspaceRoot}"
+  },
+  "tasks": [
+    {
+      "taskName": "build",
+      "args": [],
+      "isBuildCommand": true,
+      "showOutput": "silent",
+      "problemMatcher": "$msCompile"
+    }
+  ]
+}

src/Examples/OperationsExample/Startup.cs

@@ -8,7 +8,6 @@
 using System;
 using OperationsExample.Data;
 using JsonApiDotNetCore.Models;
-using JsonApiDotNetCore.Formatters;
 
 namespace OperationsExample
 {
@@ -36,15 +35,10 @@ public virtual IServiceProvider ConfigureServices(IServiceCollection services)
             services.AddDbContext<AppDbContext>(options =>
             {
                 options.UseNpgsql(GetDbConnectionString());
-            }, ServiceLifetime  .Transient);
+            }, ServiceLifetime.Transient);
 
             services.AddJsonApi<AppDbContext>(opt => opt.EnableExtension(JsonApiExtension.Operations));
 
-            services.AddMvc().AddMvcOptions(options => {
-                    options.InputFormatters.Clear();
-                    options.InputFormatters.Insert(0, new JsonApiOperationsInputFormatter());
-                });
-
             return services.BuildServiceProvider();
         }
 

src/JsonApiDotNetCore/Controllers/JsonApiOperationsController.cs

@@ -15,7 +15,7 @@ public JsonApiOperationsController(IOperationsProcessor operationsProcessor)
         }
 
         [HttpPatch]
-        public async Task<IActionResult> PatchAsync(OperationsDocument doc)
+        public async Task<IActionResult> PatchAsync([FromBody] OperationsDocument doc)
         {
             var results = await _operationsProcessor.ProcessAsync(doc.Operations);
             return Ok(results);

src/JsonApiDotNetCore/Extensions/IServiceCollectionExtensions.cs

@@ -112,6 +112,7 @@ public static void AddJsonApiInternals(
             services.AddScoped<IJsonApiWriter, JsonApiWriter>();
             services.AddScoped<IJsonApiDeSerializer, JsonApiDeSerializer>();
             services.AddScoped<IJsonApiReader, JsonApiReader>();
+            services.AddScoped<IJsonApiOperationsReader, JsonApiOperationsReader>();
             services.AddScoped<IGenericProcessorFactory, GenericProcessorFactory>();
             services.AddScoped(typeof(GenericProcessor<>));
             services.AddScoped<IQueryAccessor, QueryAccessor>();
@@ -128,11 +129,11 @@ private static void AddOperationServices(IServiceCollection services)
 
         public static void SerializeAsJsonApi(this MvcOptions options, JsonApiOptions jsonApiOptions)
         {
+            options.InputFormatters.Insert(0, new JsonApiInputFormatter());
+
             if (jsonApiOptions.EnabledExtensions.Contains(JsonApiExtension.Operations))
                 options.InputFormatters.Insert(0, new JsonApiOperationsInputFormatter());
 
-            options.InputFormatters.Insert(0, new JsonApiInputFormatter());
-
             options.OutputFormatters.Insert(0, new JsonApiOutputFormatter());
 
             options.Conventions.Insert(0, new DasherizedRoutingConvention(jsonApiOptions.Namespace));

src/JsonApiDotNetCore/Formatters/JsonApiInputFormatter.cs

@@ -8,22 +8,19 @@ namespace JsonApiDotNetCore.Formatters
     public class JsonApiInputFormatter : IInputFormatter
     {
         public bool CanRead(InputFormatterContext context)
-        {            
+        {
             if (context == null)
                 throw new ArgumentNullException(nameof(context));
 
             var contentTypeString = context.HttpContext.Request.ContentType;
 
             var canRead = contentTypeString == "application/vnd.api+json";
 
-            Console.WriteLine($">>> JsonApiInputFormatter Can Read {canRead}");
-
             return canRead;
         }
 
         public async Task<InputFormatterResult> ReadAsync(InputFormatterContext context)
         {
-            Console.WriteLine($">>> JsonApiInputFormatter ReadAsync");
             var reader = context.HttpContext.RequestServices.GetService<IJsonApiReader>();
             return await reader.ReadAsync(context);
         }

src/JsonApiDotNetCore/Formatters/JsonApiOperationsInputFormatter.cs

@@ -1,25 +1,16 @@
 using System;
-using System.Text;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc.Formatters;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Primitives;
-using Microsoft.Net.Http.Headers;
 
 namespace JsonApiDotNetCore.Formatters
 {
-    public class JsonApiOperationsInputFormatter : TextInputFormatter
+    public class JsonApiOperationsInputFormatter : IInputFormatter
     {
         const string PROFILE_EXTENSION = "<http://example.org/profiles/myjsonstuff>; rel=\"profile\"";
 
-        public JsonApiOperationsInputFormatter()
-        {
-            SupportedMediaTypes.Add(MediaTypeHeaderValue.Parse("application/vnd.api+json"));
-            SupportedEncodings.Add(Encoding.UTF8);
-            SupportedEncodings.Add(Encoding.Unicode);
-        }
-
-        public override bool CanRead(InputFormatterContext context)
+        public bool CanRead(InputFormatterContext context)
         {
             if (context == null)
                 throw new ArgumentNullException(nameof(context));
@@ -31,13 +22,12 @@ public override bool CanRead(InputFormatterContext context)
                 context.HttpContext.Request.Headers.TryGetValue("Link", out StringValues profileExtension) &&
                 profileExtension == PROFILE_EXTENSION
             );
-            Console.WriteLine($">>> JsonApiOperationsInputFormatter Can Read {canRead}");
+
             return canRead;
         }
 
-        public override async Task<InputFormatterResult> ReadRequestBodyAsync(InputFormatterContext context, Encoding encoding)
+        public async Task<InputFormatterResult> ReadAsync(InputFormatterContext context)
         {
-            Console.WriteLine($">>> JsonApiOperationsInputFormatter ReadAsync");
             var reader = context.HttpContext.RequestServices.GetService<IJsonApiOperationsReader>();
             return await reader.ReadAsync(context);
         }