Removed pointless assertion (the preceeding code casts to HasManyAttribute, so this can never fail)

bkoelman · bkoelman · commit bcc297515ef0 · 2023-02-28T11:13:55.000+01:00
diff --git a/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs b/src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs
@@ -529,8 +529,6 @@ public virtual async Task RemoveFromToManyRelationshipAsync(TResource leftResour
 
             if (!rightResourceIdsToStore.SetEquals(rightResourceIdsStored))
             {
-                AssertIsNotClearingRequiredToOneRelationship(relationship, leftResourceTracked, rightResourceIdsToStore);
-
                 await UpdateRelationshipAsync(relationship, leftResourceTracked, rightResourceIdsToStore, cancellationToken);
 
                 await _resourceDefinitionAccessor.OnWritingAsync(leftResourceTracked, WriteOperationKind.RemoveFromRelationship, cancellationToken);

Original file line number	Diff line number	Diff line change
`@@ -529,8 +529,6 @@ public virtual async Task RemoveFromToManyRelationshipAsync(TResource leftResour`
`529`	`529`
`530`	`530`	`if (!rightResourceIdsToStore.SetEquals(rightResourceIdsStored))`
`531`	`531`	`{`
`532`		`- AssertIsNotClearingRequiredToOneRelationship(relationship, leftResourceTracked, rightResourceIdsToStore);`
`533`		`-`
`534`	`532`	`await UpdateRelationshipAsync(relationship, leftResourceTracked, rightResourceIdsToStore, cancellationToken);`
`535`	`533`
`536`	`534`	`await _resourceDefinitionAccessor.OnWritingAsync(leftResourceTracked, WriteOperationKind.RemoveFromRelationship, cancellationToken);`