Log resource graph validation warnings at configuration time instead of postponing them.

Bart Koelman · Bart Koelman · commit b55c2959f5d3 · 2020-04-29T12:41:32.000+02:00
diff --git a/benchmarks/DependencyFactory.cs b/benchmarks/DependencyFactory.cs
@@ -4,6 +4,7 @@
 using JsonApiDotNetCore.Internal.Contracts;
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Query;
+using Microsoft.Extensions.Logging.Abstractions;
 using Moq;
 
 namespace Benchmarks
@@ -12,7 +13,7 @@ internal static class DependencyFactory
     {
         public static IResourceGraph CreateResourceGraph(IJsonApiOptions options)
         {
-            IResourceGraphBuilder builder = new ResourceGraphBuilder(options);
+            IResourceGraphBuilder builder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
             builder.AddResource<BenchmarkResource>(BenchmarkResourcePublicNames.Type);
             return builder.Build();
         }
diff --git a/src/JsonApiDotNetCore/Builders/JsonApiApplicationBuilder.cs b/src/JsonApiDotNetCore/Builders/JsonApiApplicationBuilder.cs
@@ -66,7 +66,7 @@ public void ConfigureMvc(Type dbContextType)
             _resourceGraphBuilder = intermediateProvider.GetRequiredService<IResourceGraphBuilder>();
             _serviceDiscoveryFacade = intermediateProvider.GetRequiredService<IServiceDiscoveryFacade>();
             _dbContextType = dbContextType;
-            
+
             AddResourceTypesFromDbContext(intermediateProvider);
 
             var exceptionFilterProvider = intermediateProvider.GetRequiredService<IJsonApiExceptionFilterProvider>();
diff --git a/src/JsonApiDotNetCore/Builders/ResourceGraphBuilder.cs b/src/JsonApiDotNetCore/Builders/ResourceGraphBuilder.cs
@@ -18,20 +18,20 @@ namespace JsonApiDotNetCore.Builders
     public class ResourceGraphBuilder : IResourceGraphBuilder
     {
         private readonly IJsonApiOptions _options;
+        private readonly ILogger<ResourceGraphBuilder> _logger;
         private readonly List<ResourceContext> _resources = new List<ResourceContext>();
-        private readonly List<ValidationResult> _validationResults = new List<ValidationResult>();
 
-        public ResourceGraphBuilder(IJsonApiOptions options)
+        public ResourceGraphBuilder(IJsonApiOptions options, ILoggerFactory loggerFactory)
         {
             _options = options;
+            _logger = loggerFactory.CreateLogger<ResourceGraphBuilder>();
         }
 
         /// <inheritdoc />
         public IResourceGraph Build()
         {
             _resources.ForEach(SetResourceLinksOptions);
-            var resourceGraph = new ResourceGraph(_resources, _validationResults);
-            return resourceGraph;
+            return new ResourceGraph(_resources);
         }
 
         private void SetResourceLinksOptions(ResourceContext resourceContext)
@@ -67,7 +67,7 @@ public IResourceGraphBuilder AddResource(Type resourceType, Type idType = null,
                 }
                 else
                 {
-                    _validationResults.Add(new ValidationResult(LogLevel.Warning, $"{resourceType} does not implement '{nameof(IIdentifiable)}'. "));
+                    _logger.LogWarning($"Entity '{resourceType}' does not implement '{nameof(IIdentifiable)}'.");
                 }
             }
 
diff --git a/src/JsonApiDotNetCore/Extensions/ApplicationBuilderExtensions.cs b/src/JsonApiDotNetCore/Extensions/ApplicationBuilderExtensions.cs
@@ -1,10 +1,7 @@
-using JsonApiDotNetCore.Builders;
 using JsonApiDotNetCore.Internal;
-using JsonApiDotNetCore.Internal.Contracts;
 using JsonApiDotNetCore.Middleware;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 
 namespace JsonApiDotNetCore
 {
@@ -31,7 +28,6 @@ public static class ApplicationBuilderExtensions
         /// </example>
         public static void UseJsonApi(this IApplicationBuilder app, bool skipRegisterMiddleware = false, bool useAuthentication = false, bool useAuthorization = false)
         {
-            LogResourceGraphValidations(app);
             using (var scope = app.ApplicationServices.CreateScope())
             {
                 var inverseRelationshipResolver = scope.ServiceProvider.GetService<IInverseRelationships>();
@@ -60,16 +56,5 @@ public static void UseJsonApi(this IApplicationBuilder app, bool skipRegisterMid
                 app.UseEndpoints(endpoints => endpoints.MapControllers());
             }
         }
-
-        private static void LogResourceGraphValidations(IApplicationBuilder app)
-        {
-            var logger = (ILogger)app.ApplicationServices.GetService(typeof(ILogger<ResourceGraphBuilder>));
-            var resourceGraph = (ResourceGraph)app.ApplicationServices.GetService(typeof(IResourceGraph));
-
-            if (logger != null)
-            {
-                resourceGraph?.ValidationResults.ForEach(v => logger.Log(v.LogLevel, null, v.Message));
-            }
-        }
     }
 }
diff --git a/src/JsonApiDotNetCore/Internal/ResourceGraph.cs b/src/JsonApiDotNetCore/Internal/ResourceGraph.cs
@@ -12,13 +12,11 @@ namespace JsonApiDotNetCore.Internal
     /// </summary>
     public class ResourceGraph : IResourceGraph
     {
-        internal List<ValidationResult> ValidationResults { get; }
         private List<ResourceContext> Resources { get; }
 
-        public ResourceGraph(List<ResourceContext> resources, List<ValidationResult> validationResults = null)
+        public ResourceGraph(List<ResourceContext> resources)
         {
             Resources = resources;
-            ValidationResults = validationResults;
         }
 
         /// <inheritdoc />
diff --git a/test/DiscoveryTests/ServiceDiscoveryFacadeTests.cs b/test/DiscoveryTests/ServiceDiscoveryFacadeTests.cs
@@ -18,6 +18,7 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
 using Moq;
 using Xunit;
 
@@ -46,7 +47,7 @@ public ServiceDiscoveryFacadeTests()
             _services.AddScoped((_) => new Mock<IResourceContextProvider>().Object);
             _services.AddScoped(typeof(IResourceChangeTracker<>), typeof(DefaultResourceChangeTracker<>));
 
-            _resourceGraphBuilder = new ResourceGraphBuilder(options);
+            _resourceGraphBuilder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
         }
 
         private ServiceDiscoveryFacade Facade => new ServiceDiscoveryFacade(_services, _resourceGraphBuilder);
diff --git a/test/IntegrationTests/Data/EntityRepositoryTests.cs b/test/IntegrationTests/Data/EntityRepositoryTests.cs
@@ -162,7 +162,7 @@ public async Task Paging_PageNumberIsNegative_GiveBackReverseAmountOfIds(int pag
         {
             var contextResolverMock = new Mock<IDbContextResolver>();
             contextResolverMock.Setup(m => m.GetContext()).Returns(context);
-            var resourceGraph = new ResourceGraphBuilder(new JsonApiOptions()).AddResource<TodoItem>().Build();
+            var resourceGraph = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance).AddResource<TodoItem>().Build();
             var targetedFields = new Mock<ITargetedFields>();
             var repository = new DefaultResourceRepository<TodoItem>(targetedFields.Object, contextResolverMock.Object, resourceGraph, null, NullLoggerFactory.Instance);
             return (repository, targetedFields);
diff --git a/test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DeeplyNestedInclusionTests.cs b/test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/DeeplyNestedInclusionTests.cs
@@ -11,6 +11,7 @@
 using JsonApiDotNetCoreExample.Models;
 using JsonApiDotNetCoreExampleTests.Helpers.Extensions;
 using JsonApiDotNetCoreExampleTests.Helpers.Models;
+using Microsoft.Extensions.Logging.Abstractions;
 using Newtonsoft.Json;
 using Xunit;
 using Person = JsonApiDotNetCoreExample.Models.Person;
@@ -42,7 +43,11 @@ public async Task Can_Include_Nested_Relationships()
             const string route = "/api/v1/todoItems?include=collection.owner";
 
             var options = _fixture.GetService<IJsonApiOptions>();
-            var resourceGraph = new ResourceGraphBuilder(options).AddResource<TodoItemClient>("todoItems").AddResource<TodoItemCollection, Guid>().AddResource<Person>().Build();
+            var resourceGraph = new ResourceGraphBuilder(options, NullLoggerFactory.Instance)
+                .AddResource<TodoItemClient>("todoItems")
+                .AddResource<TodoItemCollection, Guid>()
+                .AddResource<Person>()
+                .Build();
             var deserializer = new ResponseDeserializer(resourceGraph);
             var todoItem = new TodoItem
             {
diff --git a/test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/EndToEndTest.cs b/test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/EndToEndTest.cs
@@ -17,6 +17,7 @@
 using JsonApiDotNetCoreExampleTests.Helpers.Models;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
+using Microsoft.Extensions.Logging.Abstractions;
 using Xunit;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
@@ -78,7 +79,7 @@ protected IResponseDeserializer GetDeserializer()
             var options = GetService<IJsonApiOptions>();
             var formatter = new ResourceNameFormatter(options);
             var resourcesContexts = GetService<IResourceGraph>().GetResourceContexts();
-            var builder = new ResourceGraphBuilder(options);
+            var builder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
             foreach (var rc in resourcesContexts)
             {
                 if (rc.ResourceType == typeof(TodoItem) || rc.ResourceType == typeof(TodoItemCollection))
diff --git a/test/JsonApiDotNetCoreExampleTests/Acceptance/TestFixture.cs b/test/JsonApiDotNetCoreExampleTests/Acceptance/TestFixture.cs
@@ -13,6 +13,7 @@
 using JsonApiDotNetCoreExampleTests.Helpers.Models;
 using JsonApiDotNetCoreExample.Models;
 using JsonApiDotNetCore.Internal.Contracts;
+using Microsoft.Extensions.Logging.Abstractions;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance
 {
@@ -50,7 +51,7 @@ public IResponseDeserializer GetDeserializer()
         {
             var options = GetService<IJsonApiOptions>();
 
-            var resourceGraph = new ResourceGraphBuilder(options)
+            var resourceGraph = new ResourceGraphBuilder(options, NullLoggerFactory.Instance)
                 .AddResource<PersonRole>()
                 .AddResource<Article>()
                 .AddResource<Tag>()
diff --git a/test/NoEntityFrameworkTests/TestFixture.cs b/test/NoEntityFrameworkTests/TestFixture.cs
@@ -9,6 +9,7 @@
 using System;
 using System.Linq.Expressions;
 using JsonApiDotNetCore.Configuration;
+using Microsoft.Extensions.Logging.Abstractions;
 using NoEntityFrameworkExample;
 
 namespace NoEntityFrameworkTests
@@ -42,7 +43,7 @@ public IResponseDeserializer GetDeserializer()
         {
             var options = GetService<IJsonApiOptions>();
 
-            var resourceGraph = new ResourceGraphBuilder(options).AddResource<TodoItem>("todoItems").Build();
+            var resourceGraph = new ResourceGraphBuilder(options, NullLoggerFactory.Instance).AddResource<TodoItem>("todoItems").Build();
             return new ResponseDeserializer(resourceGraph);
         }
 
diff --git a/test/UnitTests/Builders/ContextGraphBuilder_Tests.cs b/test/UnitTests/Builders/ContextGraphBuilder_Tests.cs
@@ -8,6 +8,7 @@
 using JsonApiDotNetCore.Models;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging.Abstractions;
 using Xunit;
 
 namespace UnitTests
@@ -33,6 +34,7 @@ public void Can_Build_ResourceGraph_Using_Builder()
         {
             // Arrange
             var services = new ServiceCollection();
+            services.AddLogging();
             services.AddDbContext<TestContext>();
             
             services.AddJsonApi<TestContext>(resources: builder => builder.AddResource<NonDbResource>("nonDbResources"));
@@ -53,7 +55,7 @@ public void Can_Build_ResourceGraph_Using_Builder()
         public void Resources_Without_Names_Specified_Will_Use_Configured_Formatter()
         {
             // Arrange
-            var builder = new ResourceGraphBuilder(new JsonApiOptions());
+            var builder = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance);
             builder.AddResource<TestResource>();
 
             // Act
@@ -68,7 +70,7 @@ public void Resources_Without_Names_Specified_Will_Use_Configured_Formatter()
         public void Attrs_Without_Names_Specified_Will_Use_Configured_Formatter()
         {
             // Arrange
-            var builder = new ResourceGraphBuilder(new JsonApiOptions());
+            var builder = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance);
             builder.AddResource<TestResource>();
 
             // Act
@@ -83,7 +85,7 @@ public void Attrs_Without_Names_Specified_Will_Use_Configured_Formatter()
         public void Relationships_Without_Names_Specified_Will_Use_Configured_Formatter()
         {
             // Arrange
-            var builder = new ResourceGraphBuilder(new JsonApiOptions());
+            var builder = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance);
             builder.AddResource<TestResource>();
 
             // Act
diff --git a/test/UnitTests/Extensions/IServiceCollectionExtensionsTests.cs b/test/UnitTests/Extensions/IServiceCollectionExtensionsTests.cs
@@ -64,7 +64,7 @@ public void RegisterResource_DeviatingDbContextPropertyName_RegistersCorrectly()
         {
             // Arrange
             var services = new ServiceCollection();
-
+            services.AddLogging();
             services.AddDbContext<AppDbContext>(options => options.UseInMemoryDatabase("UnitTestDb"), ServiceLifetime.Transient);
             services.AddJsonApi<AppDbContext>();
 
@@ -141,6 +141,7 @@ public void AddJsonApi_With_Context_Uses_Resource_Type_Name_If_NoOtherSpecified(
         {
             // Arrange
             var services = new ServiceCollection();
+            services.AddLogging();
             services.AddDbContext<TestContext>(options => options.UseInMemoryDatabase(Guid.NewGuid().ToString()));
 
             services.AddScoped<IScopedServiceProvider, TestScopedServiceProvider>();
diff --git a/test/UnitTests/FakeLoggerFactory.cs b/test/UnitTests/FakeLoggerFactory.cs
@@ -0,0 +1,41 @@
+using System;
+using System.Collections.Generic;
+using Microsoft.Extensions.Logging;
+
+namespace UnitTests
+{
+    internal sealed class FakeLoggerFactory : ILoggerFactory, ILoggerProvider
+    {
+        public FakeLogger Logger { get; }
+
+        public FakeLoggerFactory()
+        {
+            Logger = new FakeLogger();
+        }
+
+        public ILogger CreateLogger(string categoryName) => Logger;
+
+        public void AddProvider(ILoggerProvider provider)
+        {
+        }
+
+        public void Dispose()
+        {
+        }
+
+        internal sealed class FakeLogger : ILogger
+        {
+            public List<(LogLevel LogLevel, string Text)> Messages = new List<(LogLevel, string)>();
+
+            public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception,
+                Func<TState, Exception, string> formatter)
+            {
+                var message = formatter(state, exception);
+                Messages.Add((logLevel, message));
+            }
+
+            public bool IsEnabled(LogLevel logLevel) => true;
+            public IDisposable BeginScope<TState>(TState state) => null;
+        }
+    }
+}
diff --git a/test/UnitTests/Internal/ResourceGraphBuilder_Tests.cs b/test/UnitTests/Internal/ResourceGraphBuilder_Tests.cs
@@ -3,17 +3,18 @@
 using JsonApiDotNetCore.Internal;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
 using Xunit;
 
 namespace UnitTests.Internal
 {
     public sealed class ResourceGraphBuilder_Tests
     {
         [Fact]
-        public void AddDbContext_Does_Not_Throw_If_Context_Contains_Members_That_DoNot_Implement_IIdentifiable()
+        public void AddDbContext_Does_Not_Throw_If_Context_Contains_Members_That_Do_Not_Implement_IIdentifiable()
         {
             // Arrange
-            var resourceGraphBuilder = new ResourceGraphBuilder(new JsonApiOptions());
+            var resourceGraphBuilder = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance);
 
             // Act
             resourceGraphBuilder.AddResource(typeof(TestContext));
@@ -24,18 +25,20 @@ public void AddDbContext_Does_Not_Throw_If_Context_Contains_Members_That_DoNot_I
         }
 
         [Fact]
-        public void Adding_DbContext_Members_That_DoNot_Implement_IIdentifiable_Creates_Warning()
+        public void Adding_DbContext_Members_That_Do_Not_Implement_IIdentifiable_Logs_Warning()
         {
             // Arrange
-            var resourceGraphBuilder = new ResourceGraphBuilder(new JsonApiOptions());
+            var loggerFactory = new FakeLoggerFactory();
+            var resourceGraphBuilder = new ResourceGraphBuilder(new JsonApiOptions(), loggerFactory);
+            resourceGraphBuilder.AddResource(typeof(TestContext));
 
             // Act
-            resourceGraphBuilder.AddResource(typeof(TestContext));
-            var resourceGraph = (ResourceGraph)resourceGraphBuilder.Build();
+            resourceGraphBuilder.Build();
 
             // Assert
-            Assert.Single(resourceGraph.ValidationResults);
-            Assert.Contains(resourceGraph.ValidationResults, v => v.LogLevel == LogLevel.Warning);
+            Assert.Single(loggerFactory.Logger.Messages);
+            Assert.Equal(LogLevel.Warning, loggerFactory.Logger.Messages[0].LogLevel);
+            Assert.Equal("Entity 'UnitTests.Internal.ResourceGraphBuilder_Tests+TestContext' does not implement 'IIdentifiable'.", loggerFactory.Logger.Messages[0].Text);
         }
 
         private class Foo { }
diff --git a/test/UnitTests/Models/ConstructionTests.cs b/test/UnitTests/Models/ConstructionTests.cs
@@ -4,6 +4,7 @@
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Serialization;
 using JsonApiDotNetCore.Serialization.Server;
+using Microsoft.Extensions.Logging.Abstractions;
 using Xunit;
 
 namespace UnitTests.Models
@@ -14,7 +15,7 @@ public sealed class ConstructionTests
         public void When_model_has_no_parameterless_contructor_it_must_fail()
         {
             // Arrange
-            var graph = new ResourceGraphBuilder(new JsonApiOptions()).AddResource<ResourceWithParameters>().Build();
+            var graph = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance).AddResource<ResourceWithParameters>().Build();
 
             var serializer = new RequestDeserializer(graph, new TargetedFields());
 
diff --git a/test/UnitTests/Models/ResourceDefinitionTests.cs b/test/UnitTests/Models/ResourceDefinitionTests.cs
@@ -3,6 +3,7 @@
 using JsonApiDotNetCore.Models;
 using System.Linq;
 using JsonApiDotNetCore.Configuration;
+using Microsoft.Extensions.Logging.Abstractions;
 using Xunit;
 
 namespace UnitTests.Models
@@ -48,7 +49,7 @@ public sealed class RequestFilteredResource : ResourceDefinition<Model>
     {
         // this constructor will be resolved from the container
         // that means you can take on any dependency that is also defined in the container
-        public RequestFilteredResource(bool isAdmin) : base(new ResourceGraphBuilder(new JsonApiOptions()).AddResource<Model>().Build())
+        public RequestFilteredResource(bool isAdmin) : base(new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance).AddResource<Model>().Build())
         {
             if (isAdmin)
                 HideFields(m => m.AlwaysExcluded);
diff --git a/test/UnitTests/QueryParameters/QueryParametersUnitTestCollection.cs b/test/UnitTests/QueryParameters/QueryParametersUnitTestCollection.cs
diff --git a/test/UnitTests/ResourceHooks/DiscoveryTests.cs b/test/UnitTests/ResourceHooks/DiscoveryTests.cs
diff --git a/test/UnitTests/ResourceHooks/ResourceHooksTestsSetup.cs b/test/UnitTests/ResourceHooks/ResourceHooksTestsSetup.cs
diff --git a/test/UnitTests/Serialization/SerializationTestsSetupBase.cs b/test/UnitTests/Serialization/SerializationTestsSetupBase.cs
diff --git a/test/UnitTests/Services/EntityResourceService_Tests.cs b/test/UnitTests/Services/EntityResourceService_Tests.cs

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`using JsonApiDotNetCore.Internal.Contracts;`
`5`	`5`	`using JsonApiDotNetCore.Models;`
`6`	`6`	`using JsonApiDotNetCore.Query;`
	`7`	`+using Microsoft.Extensions.Logging.Abstractions;`
`7`	`8`	`using Moq;`
`8`	`9`
`9`	`10`	`namespace Benchmarks`
`@@ -12,7 +13,7 @@ internal static class DependencyFactory`
`12`	`13`	`{`
`13`	`14`	`public static IResourceGraph CreateResourceGraph(IJsonApiOptions options)`
`14`	`15`	`{`
`15`		`- IResourceGraphBuilder builder = new ResourceGraphBuilder(options);`
	`16`	`+ IResourceGraphBuilder builder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);`
`16`	`17`	`builder.AddResource<BenchmarkResource>(BenchmarkResourcePublicNames.Type);`
`17`	`18`	`return builder.Build();`
`18`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,20 +18,20 @@ namespace JsonApiDotNetCore.Builders`
`18`	`18`	`public class ResourceGraphBuilder : IResourceGraphBuilder`
`19`	`19`	`{`
`20`	`20`	`private readonly IJsonApiOptions _options;`
	`21`	`+ private readonly ILogger<ResourceGraphBuilder> _logger;`
`21`	`22`	`private readonly List<ResourceContext> _resources = new List<ResourceContext>();`
`22`		`- private readonly List<ValidationResult> _validationResults = new List<ValidationResult>();`
`23`	`23`
`24`		`- public ResourceGraphBuilder(IJsonApiOptions options)`
	`24`	`+ public ResourceGraphBuilder(IJsonApiOptions options, ILoggerFactory loggerFactory)`
`25`	`25`	`{`
`26`	`26`	`_options = options;`
	`27`	`+ _logger = loggerFactory.CreateLogger<ResourceGraphBuilder>();`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`/// <inheritdoc />`
`30`	`31`	`public IResourceGraph Build()`
`31`	`32`	`{`
`32`	`33`	`_resources.ForEach(SetResourceLinksOptions);`
`33`		`- var resourceGraph = new ResourceGraph(_resources, _validationResults);`
`34`		`- return resourceGraph;`
	`34`	`+ return new ResourceGraph(_resources);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`private void SetResourceLinksOptions(ResourceContext resourceContext)`
`@@ -67,7 +67,7 @@ public IResourceGraphBuilder AddResource(Type resourceType, Type idType = null,`
`67`	`67`	`}`
`68`	`68`	`else`
`69`	`69`	`{`
`70`		`- _validationResults.Add(new ValidationResult(LogLevel.Warning, $"{resourceType} does not implement '{nameof(IIdentifiable)}'. "));`
	`70`	`+ _logger.LogWarning($"Entity '{resourceType}' does not implement '{nameof(IIdentifiable)}'.");`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,7 @@`
`1`		`-using JsonApiDotNetCore.Builders;`
`2`	`1`	`using JsonApiDotNetCore.Internal;`
`3`		`-using JsonApiDotNetCore.Internal.Contracts;`
`4`	`2`	`using JsonApiDotNetCore.Middleware;`
`5`	`3`	`using Microsoft.AspNetCore.Builder;`
`6`	`4`	`using Microsoft.Extensions.DependencyInjection;`
`7`		`-using Microsoft.Extensions.Logging;`
`8`	`5`
`9`	`6`	`namespace JsonApiDotNetCore`
`10`	`7`	`{`
`@@ -31,7 +28,6 @@ public static class ApplicationBuilderExtensions`
`31`	`28`	`/// </example>`
`32`	`29`	`public static void UseJsonApi(this IApplicationBuilder app, bool skipRegisterMiddleware = false, bool useAuthentication = false, bool useAuthorization = false)`
`33`	`30`	`{`
`34`		`- LogResourceGraphValidations(app);`
`35`	`31`	`using (var scope = app.ApplicationServices.CreateScope())`
`36`	`32`	`{`
`37`	`33`	`var inverseRelationshipResolver = scope.ServiceProvider.GetService<IInverseRelationships>();`
`@@ -60,16 +56,5 @@ public static void UseJsonApi(this IApplicationBuilder app, bool skipRegisterMid`
`60`	`56`	`app.UseEndpoints(endpoints => endpoints.MapControllers());`
`61`	`57`	`}`
`62`	`58`	`}`
`63`		`-`
`64`		`- private static void LogResourceGraphValidations(IApplicationBuilder app)`
`65`		`- {`
`66`		`- var logger = (ILogger)app.ApplicationServices.GetService(typeof(ILogger<ResourceGraphBuilder>));`
`67`		`- var resourceGraph = (ResourceGraph)app.ApplicationServices.GetService(typeof(IResourceGraph));`
`68`		`-`
`69`		`- if (logger != null)`
`70`		`- {`
`71`		`- resourceGraph?.ValidationResults.ForEach(v => logger.Log(v.LogLevel, null, v.Message));`
`72`		`- }`
`73`		`- }`
`74`	`59`	`}`
`75`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,11 @@ namespace JsonApiDotNetCore.Internal`
`12`	`12`	`/// </summary>`
`13`	`13`	`public class ResourceGraph : IResourceGraph`
`14`	`14`	`{`
`15`		`- internal List<ValidationResult> ValidationResults { get; }`
`16`	`15`	`private List<ResourceContext> Resources { get; }`
`17`	`16`
`18`		`- public ResourceGraph(List<ResourceContext> resources, List<ValidationResult> validationResults = null)`
	`17`	`+ public ResourceGraph(List<ResourceContext> resources)`
`19`	`18`	`{`
`20`	`19`	`Resources = resources;`
`21`		`- ValidationResults = validationResults;`
`22`	`20`	`}`
`23`	`21`
`24`	`22`	`/// <inheritdoc />`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public async Task Paging_PageNumberIsNegative_GiveBackReverseAmountOfIds(int pag`
`162`	`162`	`{`
`163`	`163`	`var contextResolverMock = new Mock<IDbContextResolver>();`
`164`	`164`	`contextResolverMock.Setup(m => m.GetContext()).Returns(context);`
`165`		`- var resourceGraph = new ResourceGraphBuilder(new JsonApiOptions()).AddResource<TodoItem>().Build();`
	`165`	`+ var resourceGraph = new ResourceGraphBuilder(new JsonApiOptions(), NullLoggerFactory.Instance).AddResource<TodoItem>().Build();`
`166`	`166`	`var targetedFields = new Mock<ITargetedFields>();`
`167`	`167`	`var repository = new DefaultResourceRepository<TodoItem>(targetedFields.Object, contextResolverMock.Object, resourceGraph, null, NullLoggerFactory.Instance);`
`168`	`168`	`return (repository, targetedFields);`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`using JsonApiDotNetCoreExampleTests.Helpers.Models;`
`14`	`14`	`using JsonApiDotNetCoreExample.Models;`
`15`	`15`	`using JsonApiDotNetCore.Internal.Contracts;`
	`16`	`+using Microsoft.Extensions.Logging.Abstractions;`
`16`	`17`
`17`	`18`	`namespace JsonApiDotNetCoreExampleTests.Acceptance`
`18`	`19`	`{`
`@@ -50,7 +51,7 @@ public IResponseDeserializer GetDeserializer()`
`50`	`51`	`{`
`51`	`52`	`var options = GetService<IJsonApiOptions>();`
`52`	`53`
`53`		`- var resourceGraph = new ResourceGraphBuilder(options)`
	`54`	`+ var resourceGraph = new ResourceGraphBuilder(options, NullLoggerFactory.Instance)`
`54`	`55`	`.AddResource<PersonRole>()`
`55`	`56`	`.AddResource<Article>()`
`56`	`57`	`.AddResource<Tag>()`