Changed TransactionId from Guid to String, to make it easier to support non-EF Core scenarios.

Author: Bart Koelman

src/JsonApiDotNetCore/AtomicOperations/EntityFrameworkCoreTransaction.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Threading;
 using System.Threading.Tasks;
 using JetBrains.Annotations;
@@ -18,7 +17,7 @@ public sealed class EntityFrameworkCoreTransaction : IOperationsTransaction
         private readonly DbContext _dbContext;
 
         /// <inheritdoc />
-        public Guid TransactionId => _transaction.TransactionId;
+        public string TransactionId => _transaction.TransactionId.ToString();
 
         public EntityFrameworkCoreTransaction(IDbContextTransaction transaction, DbContext dbContext)
         {

src/JsonApiDotNetCore/AtomicOperations/IOperationsTransaction.cs

@@ -14,7 +14,7 @@ public interface IOperationsTransaction : IAsyncDisposable
         /// <summary>
         /// Identifies the active transaction.
         /// </summary>
-        Guid TransactionId { get; }
+        string TransactionId { get; }
 
         /// <summary>
         /// Enables to execute custom logic before processing of an operation starts.

src/JsonApiDotNetCore/Middleware/IJsonApiRequest.cs

@@ -1,4 +1,3 @@
-using System;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Resources.Annotations;
 
@@ -65,7 +64,7 @@ public interface IJsonApiRequest
         /// <summary>
         /// In case of an atomic:operations request, identifies the overarching transaction.
         /// </summary>
-        Guid? TransactionId { get; }
+        string TransactionId { get; }
 
         /// <summary>
         /// Performs a shallow copy.

src/JsonApiDotNetCore/Middleware/JsonApiRequest.cs

@@ -1,4 +1,3 @@
-using System;
 using JetBrains.Annotations;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Resources.Annotations;
@@ -37,7 +36,7 @@ public sealed class JsonApiRequest : IJsonApiRequest
         public OperationKind? OperationKind { get; set; }
 
         /// <inheritdoc />
-        public Guid? TransactionId { get; set; }
+        public string TransactionId { get; set; }
 
         /// <inheritdoc />
         public void CopyFrom(IJsonApiRequest other)

src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs

@@ -37,7 +37,7 @@ public class EntityFrameworkCoreRepository<TResource, TId> : IResourceRepository
         private readonly TraceLogWriter<EntityFrameworkCoreRepository<TResource, TId>> _traceWriter;
 
         /// <inheritdoc />
-        public virtual Guid? TransactionId => _dbContext.Database.CurrentTransaction?.TransactionId;
+        public virtual string TransactionId => _dbContext.Database.CurrentTransaction?.TransactionId.ToString();
 
         public EntityFrameworkCoreRepository(ITargetedFields targetedFields, IDbContextResolver contextResolver, IResourceGraph resourceGraph,
             IResourceFactory resourceFactory, IEnumerable<IQueryConstraintProvider> constraintProviders, ILoggerFactory loggerFactory)

src/JsonApiDotNetCore/Repositories/IRepositorySupportsTransaction.cs

@@ -1,4 +1,3 @@
-using System;
 using JetBrains.Annotations;
 
 namespace JsonApiDotNetCore.Repositories
@@ -12,6 +11,6 @@ public interface IRepositorySupportsTransaction
         /// <summary>
         /// Identifies the currently active transaction.
         /// </summary>
-        Guid? TransactionId { get; }
+        string TransactionId { get; }
     }
 }

src/JsonApiDotNetCore/Resources/OperationContainer.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using JetBrains.Annotations;
 using JsonApiDotNetCore.Middleware;
@@ -31,7 +30,7 @@ public OperationContainer(OperationKind kind, IIdentifiable resource, ITargetedF
             Request = request;
         }
 
-        public void SetTransactionId(Guid transactionId)
+        public void SetTransactionId(string transactionId)
         {
             ((JsonApiRequest)Request).TransactionId = transactionId;
         }

test/JsonApiDotNetCoreExampleTests/IntegrationTests/AtomicOperations/Transactions/LyricRepository.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using JetBrains.Annotations;
 using JsonApiDotNetCore.Configuration;
@@ -14,7 +13,7 @@ public sealed class LyricRepository : EntityFrameworkCoreRepository<Lyric, long>
     {
         private readonly ExtraDbContext _extraDbContext;
 
-        public override Guid? TransactionId => _extraDbContext.Database.CurrentTransaction.TransactionId;
+        public override string TransactionId => _extraDbContext.Database.CurrentTransaction.TransactionId.ToString();
 
         public LyricRepository(ExtraDbContext extraDbContext, ITargetedFields targetedFields, IDbContextResolver contextResolver, IResourceGraph resourceGraph,
             IResourceFactory resourceFactory, IEnumerable<IQueryConstraintProvider> constraintProviders, ILoggerFactory loggerFactory)

test/JsonApiDotNetCoreExampleTests/IntegrationTests/AtomicOperations/Transactions/MusicTrackRepository.cs

@@ -12,7 +12,7 @@ namespace JsonApiDotNetCoreExampleTests.IntegrationTests.AtomicOperations.Transa
     [UsedImplicitly(ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature)]
     public sealed class MusicTrackRepository : EntityFrameworkCoreRepository<MusicTrack, Guid>
     {
-        public override Guid? TransactionId => null;
+        public override string TransactionId => null;
 
         public MusicTrackRepository(ITargetedFields targetedFields, IDbContextResolver contextResolver, IResourceGraph resourceGraph,
             IResourceFactory resourceFactory, IEnumerable<IQueryConstraintProvider> constraintProviders, ILoggerFactory loggerFactory)