test(spec): server should return 400 on bad query

Author: jaredcnance

src/JsonApiDotNetCore/Internal/Error.cs

@@ -4,6 +4,9 @@ namespace JsonApiDotNetCore.Internal
 {
     public class Error
     {
+        public Error()
+        { }
+        
         public Error(string status, string title)
         {
             Status = status;

src/JsonApiDotNetCore/Internal/Query/QuerySet.cs

@@ -45,12 +45,16 @@ private void BuildQuerySet(IQueryCollection query)
                 if (pair.Key.StartsWith("include"))
                 {
                     IncludedRelationships = ParseIncludedRelationships(pair.Value);
+                    continue;
                 }
 
                 if (pair.Key.StartsWith("page"))
                 {
                     PageQuery = ParsePageQuery(pair.Key, pair.Value);
+                    continue;
                 }
+
+                throw new JsonApiException("400", $"{pair} is not a valid query.");
             }
         }
 

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/QueryParameters.cs

@@ -0,0 +1,49 @@
+using System.Net;
+using System.Net.Http;
+using System.Threading.Tasks;
+using DotNetCoreDocs;
+using DotNetCoreDocs.Models;
+using DotNetCoreDocs.Writers;
+using JsonApiDotNetCoreExample;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.TestHost;
+using Newtonsoft.Json;
+using Xunit;
+using JsonApiDotNetCore.Internal;
+
+namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
+{
+    [Collection("WebHostCollection")]
+    public class QueryParameters
+    {
+        private DocsFixture<Startup, JsonDocWriter> _fixture;
+        public QueryParameters(DocsFixture<Startup, JsonDocWriter> fixture)
+        {
+            _fixture = fixture;
+        }
+
+        [Fact]
+        public async Task Server_Returns_400_ForUnknownQueryParam()
+        {
+            // arrange
+            const string queryKey = "unknownKey";
+            const string queryValue = "value";
+            var builder = new WebHostBuilder()
+                .UseStartup<Startup>();
+            var httpMethod = new HttpMethod("GET");
+            var route = $"/api/v1/todo-items?{queryKey}={queryValue}";
+            var description = new RequestProperties("Server Returns 400 For Unknown Query Params");
+            var server = new TestServer(builder);
+            var client = server.CreateClient();
+            var request = new HttpRequestMessage(httpMethod, route);
+
+            // act
+            var response = await client.SendAsync(request);
+            var body = JsonConvert.DeserializeObject<Error>(await response.Content.ReadAsStringAsync());
+
+            // assert
+            Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+            Assert.Equal($"[{queryKey}, {queryValue}] is not a valid query.", body.Title);
+        }
+    }
+}