#258 Fixes Error in ContainsMediaTypeParameters method's logic. ContentNegotion tests pass.

Corey Floyd · Corey Floyd · commit a48fc4ca9252 · 2018-04-24T13:41:51.000-05:00
diff --git a/src/JsonApiDotNetCore/Middleware/RequestMiddleware.cs b/src/JsonApiDotNetCore/Middleware/RequestMiddleware.cs
@@ -56,10 +56,9 @@ private static bool IsValidAcceptHeader(HttpContext context)
         private static bool ContainsMediaTypeParameters(string mediaType)
         {
             const char delimeter = ';';
-            var sliceLength = mediaType.IndexOf(delimeter);
-            if (sliceLength < 0) return false;
-            var mediaTypeSlice = mediaType.AsSpan().Slice(0, sliceLength);
-            return mediaTypeSlice.Length == 2 && mediaTypeSlice.SequenceEqual(Constants.ContentType.AsSpan());
+            var subSpans = new SpanSplitter(ref mediaType, delimeter);
+            if (subSpans.Count == 0) return false;
+            return subSpans.Count == 2 && subSpans[0].ToString() == Constants.ContentType;
         }
 
         private static void FlushResponse(HttpContext context, int statusCode)

Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,9 @@ private static bool IsValidAcceptHeader(HttpContext context)`
`56`	`56`	`private static bool ContainsMediaTypeParameters(string mediaType)`
`57`	`57`	`{`
`58`	`58`	`const char delimeter = ';';`
`59`		`- var sliceLength = mediaType.IndexOf(delimeter);`
`60`		`- if (sliceLength < 0) return false;`
`61`		`- var mediaTypeSlice = mediaType.AsSpan().Slice(0, sliceLength);`
`62`		`- return mediaTypeSlice.Length == 2 && mediaTypeSlice.SequenceEqual(Constants.ContentType.AsSpan());`
	`59`	`+ var subSpans = new SpanSplitter(ref mediaType, delimeter);`
	`60`	`+ if (subSpans.Count == 0) return false;`
	`61`	`+ return subSpans.Count == 2 && subSpans[0].ToString() == Constants.ContentType;`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`private static void FlushResponse(HttpContext context, int statusCode)`