Various (non-breaking) name changes for internal consistency

Author: bkoelman

src/JsonApiDotNetCore/Queries/Internal/Parsing/FilterParser.cs

@@ -420,7 +420,7 @@ private object ConvertStringToType(string value, Type type)
 
     private Converter<string, object> GetConstantValueConverterForAttribute(AttrAttribute attribute)
     {
-        return stringValue => attribute.Property.Name == nameof(IIdentifiable<object>.Id)
+        return stringValue => attribute.Property.Name == nameof(Identifiable<object>.Id)
             ? DeObfuscateStringId(attribute.Type.ClrType, stringValue)
             : ConvertStringToType(stringValue, attribute.Property.PropertyType);
     }

src/JsonApiDotNetCore/Queries/Internal/QueryableBuilding/SelectClauseBuilder.cs

@@ -162,9 +162,9 @@ private void IncludeAllScalarProperties(Type elementType, Dictionary<PropertyInf
 
     private static void IncludeFields(FieldSelectors fieldSelectors, Dictionary<PropertyInfo, PropertySelector> propertySelectors)
     {
-        foreach ((ResourceFieldAttribute resourceField, QueryLayer? queryLayer) in fieldSelectors)
+        foreach ((ResourceFieldAttribute resourceField, QueryLayer? nextLayer) in fieldSelectors)
         {
-            var propertySelector = new PropertySelector(resourceField.Property, queryLayer);
+            var propertySelector = new PropertySelector(resourceField.Property, nextLayer);
             IncludeWritableProperty(propertySelector, propertySelectors);
         }
     }

test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/SparseFieldSets/SparseFieldSetTests.cs

@@ -791,7 +791,7 @@ public async Task Cannot_select_ToMany_relationship_with_blocked_capability()
     }
 
     [Fact]
-    public async Task Retrieves_all_properties_when_fieldset_contains_readonly_attribute()
+    public async Task Fetches_all_scalar_properties_when_fieldset_contains_readonly_attribute()
     {
         // Arrange
         var store = _testContext.Factory.Services.GetRequiredService<ResourceCaptureStore>();

test/TestBuildingBlocks/DbContextExtensions.cs

@@ -23,15 +23,15 @@ public static async Task ClearTablesAsync<TEntity1, TEntity2>(this DbContext dbC
         await ClearTablesAsync(dbContext, typeof(TEntity1), typeof(TEntity2));
     }
 
-    private static async Task ClearTablesAsync(this DbContext dbContext, params Type[] models)
+    private static async Task ClearTablesAsync(this DbContext dbContext, params Type[] modelTypes)
     {
-        foreach (Type model in models)
+        foreach (Type modelType in modelTypes)
         {
-            IEntityType? entityType = dbContext.Model.FindEntityType(model);
+            IEntityType? entityType = dbContext.Model.FindEntityType(modelType);
 
             if (entityType == null)
             {
-                throw new InvalidOperationException($"Table for '{model.Name}' not found.");
+                throw new InvalidOperationException($"Table for '{modelType.Name}' not found.");
             }
 
             string? tableName = entityType.GetTableName();
@@ -44,7 +44,7 @@ private static async Task ClearTablesAsync(this DbContext dbContext, params Type
             }
             else
             {
-                await dbContext.Database.ExecuteSqlRawAsync($"delete from \"{tableName}\"");
+                await dbContext.Database.ExecuteSqlRawAsync($"DELETE FROM \"{tableName}\"");
             }
         }
     }