fix: gitignore macOS file systems and scoped client serializer extension (#784)

maurei · web-flow · commit 9d7614f1679a · 2020-06-18T12:11:14.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -97,6 +97,9 @@ StyleCopReport.xml
 *.svclog
 *.scc
 
+# MacOS file systems
+**/.DS_STORE
+
 # Chutzpah Test files
 _Chutzpah*
 
diff --git a/src/JsonApiDotNetCore/Extensions/ServiceCollectionExtensions.cs b/src/JsonApiDotNetCore/Extensions/ServiceCollectionExtensions.cs
@@ -76,8 +76,8 @@ private static void ResolveInverseRelationships(IServiceCollection services)
         /// </summary>
         public static IServiceCollection AddClientSerialization(this IServiceCollection services)
         {
-            services.AddSingleton<IResponseDeserializer, ResponseDeserializer>();
-            services.AddSingleton<IRequestSerializer>(sp =>
+            services.AddScoped<IResponseDeserializer, ResponseDeserializer>();
+            services.AddScoped<IRequestSerializer>(sp =>
             {
                 var graph = sp.GetService<IResourceGraph>();
                 return new RequestSerializer(graph, new ResourceObjectBuilder(graph, new ResourceObjectBuilderSettings()));

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,8 @@ private static void ResolveInverseRelationships(IServiceCollection services)`
`76`	`76`	`/// </summary>`
`77`	`77`	`public static IServiceCollection AddClientSerialization(this IServiceCollection services)`
`78`	`78`	`{`
`79`		`- services.AddSingleton<IResponseDeserializer, ResponseDeserializer>();`
`80`		`- services.AddSingleton<IRequestSerializer>(sp =>`
	`79`	`+ services.AddScoped<IResponseDeserializer, ResponseDeserializer>();`
	`80`	`+ services.AddScoped<IRequestSerializer>(sp =>`
`81`	`81`	`{`
`82`	`82`	`var graph = sp.GetService<IResourceGraph>();`
`83`	`83`	`return new RequestSerializer(graph, new ResourceObjectBuilder(graph, new ResourceObjectBuilderSettings()));`