FIx source of crashing analyzer and restore

bkoelman · bkoelman · commit 7f8b7d7e3ad4 · 2024-09-26T05:34:58.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -160,9 +160,6 @@ dotnet_diagnostic.JSON002.severity = silent
 # CA1062: Validate arguments of public methods
 dotnet_code_quality.CA1062.excluded_symbol_names = Accept|DefaultVisit|Visit*|Apply*
 
-# Turn off crashing analyzer, https://github.com/dotnet/roslyn-analyzers/issues/7421
-dotnet_diagnostic.CA2263.severity = none
-
 #### .NET Naming Style ####
 
 dotnet_diagnostic.IDE1006.severity = warning
diff --git a/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/ResourceTypeCaptureStore.cs b/test/JsonApiDotNetCoreTests/IntegrationTests/ResourceInheritance/ResourceTypeCaptureStore.cs
@@ -29,7 +29,7 @@ internal void AssertLeftType<TLeft>()
         Request.ShouldNotBeNull();
         Request.PrimaryResourceType.ShouldNotBeNull();
         Request.PrimaryResourceType.ClrType.Should().Be<TLeft>();
-        Request.Relationship?.LeftType.ClrType.Should().Be(typeof(TLeft));
+        Request.Relationship?.LeftType.ClrType.Should().Be<TLeft>();
     }
 
     internal void AssertRightTypes(params Type[] types)

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ internal void AssertLeftType<TLeft>()`
`29`	`29`	`Request.ShouldNotBeNull();`
`30`	`30`	`Request.PrimaryResourceType.ShouldNotBeNull();`
`31`	`31`	`Request.PrimaryResourceType.ClrType.Should().Be<TLeft>();`
`32`		`- Request.Relationship?.LeftType.ClrType.Should().Be(typeof(TLeft));`
	`32`	`+ Request.Relationship?.LeftType.ClrType.Should().Be<TLeft>();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`internal void AssertRightTypes(params Type[] types)`