use local ids instead of JsonPointers

Author: jaredcnance

src/JsonApiDotNetCore/Services/Operations/OperationsProcessor.cs

@@ -1,8 +1,10 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
 using JsonApiDotNetCore.Data;
 using JsonApiDotNetCore.Internal;
+using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Models.Operations;
 using JsonApiDotNetCore.Models.Pointers;
 using Microsoft.EntityFrameworkCore;
@@ -61,7 +63,7 @@ private async Task ProcessOperation(Operation op, List<Operation> outputOps)
         {
             var operationsPointer = new OperationsPointer();
 
-            // ReplaceDataPointers(op.DataObject, outputOps);
+            ReplaceDataPointers(op.DataObject, outputOps);
             // ReplaceRefPointers(op.Ref, outputOps);
 
             var processor = GetOperationsProcessor(op);
@@ -71,6 +73,43 @@ private async Task ProcessOperation(Operation op, List<Operation> outputOps)
                 outputOps.Add(resultOp);
         }
 
+        private void ReplaceDataPointers(DocumentData data, List<Operation> outputOps)
+        {
+            if (data == null) return;
+
+            bool HasLocalId(ResourceIdentifierObject rio) => string.IsNullOrEmpty(rio.LocalId) == false;
+            string GetIdFromLocalId(string localId)  {
+                var referencedOp = outputOps.FirstOrDefault(o => o.DataObject.LocalId == localId);
+                if(referencedOp == null) throw new JsonApiException(400, $"Could not locate lid '{localId}' in document.");
+                return referencedOp.DataObject.Id;
+            };
+
+            // are there any circumstances where the primary data would contain an lid?
+            // if(HasLocalId(data))
+            // {
+            //     data.Id = GetIdFromLocalId(data.LocalId);
+            // }
+
+            if (data.Relationships != null) 
+            { 
+                foreach (var relationshipDictionary in data.Relationships) 
+                { 
+                    if (relationshipDictionary.Value.IsHasMany) 
+                    { 
+                        foreach (var relationship in relationshipDictionary.Value.ManyData) 
+                            if(HasLocalId(relationship))
+                                relationship.Id = GetIdFromLocalId(relationship.LocalId);
+                    } 
+                    else
+                    {
+                        var relationship = relationshipDictionary.Value.SingleData;
+                        if(HasLocalId(relationship))
+                            relationship.Id = GetIdFromLocalId(relationship.LocalId);
+                    }
+                } 
+            }
+        }
+
         private IOpProcessor GetOperationsProcessor(Operation op)
         {
             switch (op.Op)

test/UnitTests/Services/Operations/OperationsProcessorTests.cs

@@ -24,7 +24,6 @@ public OperationsProcessorTests()
             _resolverMock = new Mock<IOperationProcessorResolver>();
             _dbContextMock = new Mock<DbContext>();
             _dbContextResolverMock = new Mock<IDbContextResolver>();
-            _dbContextResolverMock.Setup(m => m.GetContext()).Returns(_dbContextMock.Object);
         }
 
         [Fact]
@@ -36,6 +35,7 @@ public async Task ProcessAsync_Performs_Pointer_ReplacementAsync()
                     ""op"": ""add"",
                     ""data"": {
                         ""type"": ""authors"",
+                        ""lid"": ""a"",
                         ""attributes"": {
                             ""name"": ""dgeb""
                         }
@@ -51,7 +51,7 @@ public async Task ProcessAsync_Performs_Pointer_ReplacementAsync()
                             ""author"": {
                                 ""data"": {
                                     ""type"": ""authors"",
-                                    ""id"": { ""pointer"": ""/operations/0/data/id"" }
+                                    ""lid"": ""a""
                                 }
                             }
                         }
@@ -66,6 +66,7 @@ public async Task ProcessAsync_Performs_Pointer_ReplacementAsync()
                 ""data"": {
                     ""type"": ""authors"",
                     ""id"": ""9"",
+                    ""lid"": ""a"",
                     ""attributes"": {
                         ""name"": ""dgeb""
                     }
@@ -91,6 +92,7 @@ public async Task ProcessAsync_Performs_Pointer_ReplacementAsync()
             _resolverMock.Setup(m => m.LocateCreateService((It.IsAny<Operation>())))
                 .Returns(opProcessorMock.Object);
 
+            _dbContextResolverMock.Setup(m => m.GetContext()).Returns(_dbContextMock.Object);
             var operationsProcessor = new OperationsProcessor(_resolverMock.Object, _dbContextResolverMock.Object);
 
             // act