fix(queryParser): remove access to obsolete key

Author: jaredcnance

src/JsonApiDotNetCore/Services/QueryAccessor.cs

@@ -69,7 +69,7 @@ private string GetFilterValue(string key) {
                 return publicValue;
 
             var internalValue = _jsonApiContext.QuerySet.Filters
-                .FirstOrDefault(f => string.Equals(f.Key, key, StringComparison.OrdinalIgnoreCase))?.Value;
+                .FirstOrDefault(f => string.Equals(f.Attribute, key, StringComparison.OrdinalIgnoreCase))?.Value;
 
             if(internalValue != null) {
                 _logger.LogWarning("Locating filters by the internal propterty name is deprecated. You should use the public attribute name instead.");

src/JsonApiDotNetCore/Services/QueryParser.cs

@@ -197,7 +197,7 @@ protected virtual AttrAttribute GetAttribute(string propertyName) {
                         string.Equals(attr.PublicAttributeName, propertyName, StringComparison.OrdinalIgnoreCase)
                     );
             } catch (InvalidOperationException e) {
-                throw new JsonApiException(400, $"Attribute '{propertyName}' does not exist on resource '{_controllerContext.RequestEntity.EntityName}'");
+                throw new JsonApiException(400, $"Attribute '{propertyName}' does not exist on resource '{_controllerContext.RequestEntity.EntityName}'", e);
             }
         }
     }

test/UnitTests/Services/QueryParser_Tests.cs

@@ -43,7 +43,7 @@ public void Can_Build_Filters()
             var querySet = queryParser.Parse(_queryCollectionMock.Object);
 
             // assert
-            Assert.Equal("value", querySet.Filters.Single(f => f.Key == "Key").Value);
+            Assert.Equal("value", querySet.Filters.Single(f => f.Attribute == "key").Value);
         }
 
         [Fact]
@@ -69,8 +69,8 @@ public void Filters_Properly_Parses_DateTime_With_Operation()
             var querySet = queryParser.Parse(_queryCollectionMock.Object);
 
             // assert
-            Assert.Equal(dt, querySet.Filters.Single(f => f.Key == "Key").Value);
-            Assert.Equal("le", querySet.Filters.Single(f => f.Key == "Key").Operation);
+            Assert.Equal(dt, querySet.Filters.Single(f => f.Attribute == "key").Value);
+            Assert.Equal("le", querySet.Filters.Single(f => f.Attribute == "key").Operation);
         }
 
         [Fact]
@@ -96,8 +96,8 @@ public void Filters_Properly_Parses_DateTime_Without_Operation()
             var querySet = queryParser.Parse(_queryCollectionMock.Object);
 
             // assert
-            Assert.Equal(dt, querySet.Filters.Single(f => f.Key == "Key").Value);
-            Assert.Equal(string.Empty, querySet.Filters.Single(f => f.Key == "Key").Operation);
+            Assert.Equal(dt, querySet.Filters.Single(f => f.Attribute == "key").Value);
+            Assert.Equal(string.Empty, querySet.Filters.Single(f => f.Attribute == "key").Operation);
         }
 
         [Fact]