Hooks fix

Bart Koelman · Bart Koelman · commit 57e07f9bee1d · 2020-04-29T12:41:33.000+02:00
diff --git a/src/JsonApiDotNetCore/Hooks/Execution/HookExecutorHelper.cs b/src/JsonApiDotNetCore/Hooks/Execution/HookExecutorHelper.cs
@@ -144,7 +144,6 @@ private IResourceReadRepository<TResource, TId> GetRepository<TResource, TId>()
             return _genericProcessorFactory.Get<IResourceReadRepository<TResource, TId>>(typeof(IResourceReadRepository<,>), typeof(TResource), typeof(TId));
         }
 
-
         public Dictionary<RelationshipAttribute, IEnumerable> LoadImplicitlyAffected(
             Dictionary<RelationshipAttribute, IEnumerable> leftEntitiesByRelation,
             IEnumerable existingRightEntities = null)
@@ -159,17 +158,20 @@ public Dictionary<RelationshipAttribute, IEnumerable> LoadImplicitlyAffected(
 
                 foreach (IIdentifiable ip in includedLefts)
                 {
-                    IList dbRightEntityList;
+                    IList dbRightEntityList = TypeHelper.CreateListFor(relationship.RightType);
                     var relationshipValue = relationship.GetValue(ip);
                     if (!(relationshipValue is IEnumerable))
                     {
-                        dbRightEntityList = TypeHelper.CreateListFor(relationship.RightType);
                         if (relationshipValue != null) dbRightEntityList.Add(relationshipValue);
                     }
                     else
                     {
-                        dbRightEntityList = (IList)relationshipValue;
+                        foreach (var item in (IEnumerable) relationshipValue)
+                        {
+                            dbRightEntityList.Add(item);
+                        }
                     }
+
                     var dbRightEntityListCast = dbRightEntityList.Cast<IIdentifiable>().ToList();
                     if (existingRightEntities != null) dbRightEntityListCast = dbRightEntityListCast.Except(existingRightEntities.Cast<IIdentifiable>(), _comparer).ToList();
 

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,6 @@ private IResourceReadRepository<TResource, TId> GetRepository<TResource, TId>()`
`144`	`144`	`return _genericProcessorFactory.Get<IResourceReadRepository<TResource, TId>>(typeof(IResourceReadRepository<,>), typeof(TResource), typeof(TId));`
`145`	`145`	`}`
`146`	`146`
`147`		`-`
`148`	`147`	`public Dictionary<RelationshipAttribute, IEnumerable> LoadImplicitlyAffected(`
`149`	`148`	`Dictionary<RelationshipAttribute, IEnumerable> leftEntitiesByRelation,`
`150`	`149`	`IEnumerable existingRightEntities = null)`
`@@ -159,17 +158,20 @@ public Dictionary<RelationshipAttribute, IEnumerable> LoadImplicitlyAffected(`
`159`	`158`
`160`	`159`	`foreach (IIdentifiable ip in includedLefts)`
`161`	`160`	`{`
`162`		`- IList dbRightEntityList;`
	`161`	`+ IList dbRightEntityList = TypeHelper.CreateListFor(relationship.RightType);`
`163`	`162`	`var relationshipValue = relationship.GetValue(ip);`
`164`	`163`	`if (!(relationshipValue is IEnumerable))`
`165`	`164`	`{`
`166`		`- dbRightEntityList = TypeHelper.CreateListFor(relationship.RightType);`
`167`	`165`	`if (relationshipValue != null) dbRightEntityList.Add(relationshipValue);`
`168`	`166`	`}`
`169`	`167`	`else`
`170`	`168`	`{`
`171`		`- dbRightEntityList = (IList)relationshipValue;`
	`169`	`+ foreach (var item in (IEnumerable) relationshipValue)`
	`170`	`+ {`
	`171`	`+ dbRightEntityList.Add(item);`
	`172`	`+ }`
`172`	`173`	`}`
	`174`	`+`
`173`	`175`	`var dbRightEntityListCast = dbRightEntityList.Cast<IIdentifiable>().ToList();`
`174`	`176`	`if (existingRightEntities != null) dbRightEntityListCast = dbRightEntityListCast.Except(existingRightEntities.Cast<IIdentifiable>(), _comparer).ToList();`
`175`	`177`