Improve test coverage

Author: bkoelman

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiMetadata/JsonApiEndpointMetadataProvider.cs

@@ -31,12 +31,14 @@ public JsonApiEndpointMetadataProvider(IControllerResourceMapping controllerReso
         ArgumentNullException.ThrowIfNull(descriptor);
 
         var actionMethod = OpenApiActionMethod.Create(descriptor);
+        JsonApiEndpointMetadata? metadata = null;
 
         switch (actionMethod)
         {
             case AtomicOperationsActionMethod:
             {
-                return new JsonApiEndpointMetadata(AtomicOperationsRequestMetadata.Instance, AtomicOperationsResponseMetadata.Instance);
+                metadata = new JsonApiEndpointMetadata(AtomicOperationsRequestMetadata.Instance, AtomicOperationsResponseMetadata.Instance);
+                break;
             }
             case JsonApiActionMethod jsonApiActionMethod:
             {
@@ -45,13 +47,13 @@ public JsonApiEndpointMetadataProvider(IControllerResourceMapping controllerReso
 
                 IJsonApiRequestMetadata? requestMetadata = GetRequestMetadata(jsonApiActionMethod.Endpoint, primaryResourceType);
                 IJsonApiResponseMetadata? responseMetadata = GetResponseMetadata(jsonApiActionMethod.Endpoint, primaryResourceType);
-                return new JsonApiEndpointMetadata(requestMetadata, responseMetadata);
-            }
-            default:
-            {
-                return null;
+                metadata = new JsonApiEndpointMetadata(requestMetadata, responseMetadata);
+                break;
             }
         }
+
+        ConsistencyGuard.ThrowIf(metadata == null);
+        return metadata;
     }
 
     private IJsonApiRequestMetadata? GetRequestMetadata(JsonApiEndpoints endpoint, ResourceType primaryResourceType)

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiRequestFormatMetadataProvider.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.AspNetCore.Mvc.Formatters;
 
@@ -10,12 +11,14 @@ namespace JsonApiDotNetCore.OpenApi.Swashbuckle;
 internal sealed class JsonApiRequestFormatMetadataProvider : IInputFormatter, IApiRequestFormatMetadataProvider
 {
     /// <inheritdoc />
+    [ExcludeFromCodeCoverage]
     public bool CanRead(InputFormatterContext context)
     {
         return false;
     }
 
     /// <inheritdoc />
+    [ExcludeFromCodeCoverage]
     public Task<InputFormatterResult> ReadAsync(InputFormatterContext context)
     {
         throw new UnreachableException();

test/OpenApiTests/MixedControllers/MixedControllerTests.cs

@@ -44,7 +44,7 @@ public async Task Default_JsonApi_endpoints_are_exposed()
     }
 
     [Fact]
-    public async Task Upload_endpoint_is_exposed()
+    public async Task Upload_file_endpoint_is_exposed()
     {
         // Act
         JsonElement document = await _testContext.GetSwaggerDocumentAsync();
@@ -97,7 +97,7 @@ public async Task Upload_endpoint_is_exposed()
     }
 
     [Fact]
-    public async Task Exists_endpoint_is_exposed()
+    public async Task File_exists_endpoint_is_exposed()
     {
         // Act
         JsonElement document = await _testContext.GetSwaggerDocumentAsync();
@@ -159,7 +159,7 @@ public async Task Exists_endpoint_is_exposed()
     }
 
     [Fact]
-    public async Task Download_endpoint_is_exposed()
+    public async Task Download_file_endpoint_is_exposed()
     {
         // Act
         JsonElement document = await _testContext.GetSwaggerDocumentAsync();
@@ -227,4 +227,139 @@ public async Task Download_endpoint_is_exposed()
             }
             """);
     }
+
+    [Fact]
+    public async Task Send_email_endpoint_is_exposed()
+    {
+        // Act
+        JsonElement document = await _testContext.GetSwaggerDocumentAsync();
+
+        // Assert
+        document.Should().ContainPath("paths./emails/send.post").Should().BeJson("""
+            {
+              "tags": [
+                "emails"
+              ],
+              "description": "Sends an email to the specified recipient.",
+              "operationId": "sendEmail",
+              "requestBody": {
+                "content": {
+                  "application/json": {
+                    "schema": {
+                      "allOf": [
+                        {
+                          "$ref": "#/components/schemas/email"
+                        }
+                      ],
+                      "description": "The email to send."
+                    }
+                  }
+                },
+                "required": true
+              },
+              "responses": {
+                "200": {
+                  "description": "OK"
+                },
+                "400": {
+                  "description": "Bad Request",
+                  "content": {
+                    "application/problem+json": {
+                      "schema": {
+                        "$ref": "#/components/schemas/httpValidationProblemDetails"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+            """);
+    }
+
+    [Fact]
+    public async Task Emails_sent_since_endpoint_is_exposed()
+    {
+        // Act
+        JsonElement document = await _testContext.GetSwaggerDocumentAsync();
+
+        // Assert
+        document.Should().ContainPath("paths./emails/sent-since.get").Should().BeJson("""
+            {
+              "tags": [
+                "emails"
+              ],
+              "description": "Gets all emails sent since the specified date/time.",
+              "operationId": "getSentSince",
+              "parameters": [
+                {
+                  "name": "sinceUtc",
+                  "in": "query",
+                  "description": "The date/time (in UTC) since which the email was sent.",
+                  "required": true,
+                  "schema": {
+                    "type": "string",
+                    "description": "The date/time (in UTC) since which the email was sent.",
+                    "format": "date-time"
+                  }
+                }
+              ],
+              "responses": {
+                "200": {
+                  "description": "OK",
+                  "content": {
+                    "application/json": {
+                      "schema": {
+                        "type": "array",
+                        "items": {
+                          "$ref": "#/components/schemas/email"
+                        }
+                      }
+                    }
+                  }
+                },
+                "400": {
+                  "description": "Bad Request",
+                  "content": {
+                    "application/problem+json": {
+                      "schema": {
+                        "$ref": "#/components/schemas/httpValidationProblemDetails"
+                      }
+                    }
+                  }
+                }
+              }
+            }
+            """);
+
+        document.Should().ContainPath("paths./emails/sent-since.head").Should().BeJson("""
+            {
+              "tags": [
+                "emails"
+              ],
+              "description": "Gets all emails sent since the specified date/time.",
+              "operationId": "tryGetSentSince",
+              "parameters": [
+                {
+                  "name": "sinceUtc",
+                  "in": "query",
+                  "description": "The date/time (in UTC) since which the email was sent.",
+                  "required": true,
+                  "schema": {
+                    "type": "string",
+                    "description": "The date/time (in UTC) since which the email was sent.",
+                    "format": "date-time"
+                  }
+                }
+              ],
+              "responses": {
+                "200": {
+                  "description": "OK"
+                },
+                "400": {
+                  "description": "Bad Request"
+                }
+              }
+            }
+            """);
+    }
 }