Remove ShouldNotBeNullOrEmpty

Author: bkoelman

test/JsonApiDotNetCoreTests/IntegrationTests/Serialization/ETagTests.cs

@@ -43,7 +43,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
 
         httpResponse.Headers.ETag.ShouldNotBeNull();
         httpResponse.Headers.ETag.IsWeak.Should().BeFalse();
-        httpResponse.Headers.ETag.Tag.ShouldNotBeNullOrEmpty();
+        httpResponse.Headers.ETag.Tag.Should().NotBeNullOrEmpty();
 
         responseDocument.Should().BeEmpty();
     }
@@ -71,7 +71,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
 
         httpResponse.Headers.ETag.ShouldNotBeNull();
         httpResponse.Headers.ETag.IsWeak.Should().BeFalse();
-        httpResponse.Headers.ETag.Tag.ShouldNotBeNullOrEmpty();
+        httpResponse.Headers.ETag.Tag.Should().NotBeNullOrEmpty();
 
         responseDocument.Should().NotBeEmpty();
     }
@@ -202,7 +202,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
 
         httpResponse2.Headers.ETag.ShouldNotBeNull();
         httpResponse2.Headers.ETag.IsWeak.Should().BeFalse();
-        httpResponse2.Headers.ETag.Tag.ShouldNotBeNullOrEmpty();
+        httpResponse2.Headers.ETag.Tag.Should().NotBeNullOrEmpty();
 
         responseDocument2.Should().BeEmpty();
     }
@@ -232,7 +232,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
 
         httpResponse.Headers.ETag.ShouldNotBeNull();
         httpResponse.Headers.ETag.IsWeak.Should().BeFalse();
-        httpResponse.Headers.ETag.Tag.ShouldNotBeNullOrEmpty();
+        httpResponse.Headers.ETag.Tag.Should().NotBeNullOrEmpty();
 
         responseDocument.Should().NotBeEmpty();
     }

test/TestBuildingBlocks/NullabilityAssertionExtensions.cs

@@ -16,12 +16,6 @@ public static T ShouldNotBeNull<T>([SysNotNull] this T? subject)
         return subject!;
     }
 
-    [CustomAssertion]
-    public static void ShouldNotBeNullOrEmpty([SysNotNull] this string? subject)
-    {
-        subject.Should().NotBeNullOrEmpty();
-    }
-
     [CustomAssertion]
     public static TValue? ShouldContainKey<TKey, TValue>([SysNotNull] this IDictionary<TKey, TValue?>? subject, TKey expected)
     {