test(extensibility): fix/remove failing tests

these tests are not currently setup correctly. they assume that a resource can be routed based on a different name (todo-items-test -> todo-items). this is not currently supported and is out of scope for this PR. I am open to discussion, but don't believe this is going to be on the roadmap.

Other changes (todoitems -> todo-items) is for the dame reason. TodoItems have been mapped to todo-items in this example so the tests would fail.

Author: jaredcnance

src/JsonApiDotNetCore/Models/RelationshipAttribute.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace JsonApiDotNetCore.Models
 {

src/JsonApiDotNetCoreExample/Controllers/TodoItemsCustomController.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using JsonApiDotNetCore.Controllers;
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Services;
 using JsonApiDotNetCoreExample.Models;
@@ -9,7 +8,7 @@
 
 namespace JsonApiDotNetCoreExample.Controllers
 {
-    [Route("custom/route/todoitems")]
+    [Route("custom/route/todo-items")]
     public class TodoItemsCustomController : CustomJsonApiController<TodoItem>
     {
         public TodoItemsCustomController(

src/JsonApiDotNetCoreExample/Controllers/TodoItemsTestController.cs

@@ -1,22 +1,24 @@
 using JsonApiDotNetCore.Controllers;
-using JsonApiDotNetCore.Data;
 using JsonApiDotNetCore.Models;
 using JsonApiDotNetCore.Services;
 using JsonApiDotNetCoreExample.Models;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Logging;
 
 namespace JsonApiDotNetCoreExample.Controllers
 {
-    public abstract class AbstractTodoItemsController<T> : JsonApiController<T> where T : class, IIdentifiable<int>
+    public abstract class AbstractTodoItemsController<T> 
+    : JsonApiController<T> where T : class, IIdentifiable<int>
     {
         protected AbstractTodoItemsController(
             IJsonApiContext jsonApiContext,
             IResourceService<T, int> service,
             ILoggerFactory loggerFactory)
             : base(jsonApiContext, service, loggerFactory)
-        {
-        }
+        { }
     }
+
+    [Route("/abstract")]
     public class TodoItemsTestController : AbstractTodoItemsController<TodoItem>
     {
         public TodoItemsTestController(

test/JsonApiDotNetCoreExampleTests/Acceptance/Extensibility/CustomControllerTests.cs

@@ -4,8 +4,6 @@
 using Bogus;
 using DotNetCoreDocs;
 using DotNetCoreDocs.Writers;
-using JsonApiDotNetCore.Models;
-using JsonApiDotNetCore.Services;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
 using Xunit;
@@ -56,91 +54,14 @@ public async Task NonJsonApiControllers_DoNotUse_Dasherized_Routes()
             Assert.Equal(HttpStatusCode.OK, response.StatusCode);
         }
 
-        [Fact]
-        public async Task InheritedJsonApiControllers_Uses_Dasherized_Collection_Route()
-        {
-            // Arrange
-            var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
-            var httpMethod = new HttpMethod("GET");
-            var route = "/api/v1/todo-items-test";
-
-            var server = new TestServer(builder);
-            var client = server.CreateClient();
-            var request = new HttpRequestMessage(httpMethod, route);
-
-            // act
-            var response = await client.SendAsync(request);
-
-            // assert
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-        }
-
-        [Fact]
-        public async Task InheritedJsonApiControllers_Uses_Dasherized_Item_Route()
-        {
-            // Arrange
-            var context = _fixture.GetService<AppDbContext>();
-            var todoItem = _todoItemFaker.Generate();
-            var person = _personFaker.Generate();
-            todoItem.Owner = person;
-            context.TodoItems.Add(todoItem);
-            await context.SaveChangesAsync();
-
-            var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
-            var httpMethod = new HttpMethod("GET");
-            var route = $"/api/v1/todo-items-test/{todoItem.Id}";
-
-            var server = new TestServer(builder);
-            var client = server.CreateClient();
-            var request = new HttpRequestMessage(httpMethod, route);
-
-            // act
-            var response = await client.SendAsync(request);
-
-            // assert
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-        }
-
-        [Fact]
-        public async Task InheritedJsonApiControllers_Creates_Proper_Relationship_Links()
-        {
-            // Arrange
-            var context = _fixture.GetService<AppDbContext>();
-            var todoItem = _todoItemFaker.Generate();
-            var person = _personFaker.Generate();
-            todoItem.Owner = person;
-            context.TodoItems.Add(todoItem);
-            await context.SaveChangesAsync();
-
-            var builder = new WebHostBuilder()
-                .UseStartup<Startup>();
-            var httpMethod = new HttpMethod("GET");
-            var route = $"/api/v1/todo-items-test/{todoItem.Id}";
-
-            var server = new TestServer(builder);
-            var client = server.CreateClient();
-            var request = new HttpRequestMessage(httpMethod, route);
-
-            // act & assert
-            var response = await client.SendAsync(request);
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-
-            var body = await response.Content.ReadAsStringAsync();
-            var deserializedBody = JsonConvert.DeserializeObject<JObject>(body);
-
-            Assert.EndsWith($"{route}/owner", deserializedBody["data"]["relationships"]["owner"]["links"]["related"].ToString());
-        }
-
         [Fact]
         public async Task CustomRouteControllers_Uses_Dasherized_Collection_Route()
         {
             // Arrange
             var builder = new WebHostBuilder()
                 .UseStartup<Startup>();
             var httpMethod = new HttpMethod("GET");
-            var route = $"/custom/route/todoitems";
+            var route = $"/custom/route/todo-items";
 
             var server = new TestServer(builder);
             var client = server.CreateClient();
@@ -167,7 +88,7 @@ public async Task CustomRouteControllers_Uses_Dasherized_Item_Route()
             var builder = new WebHostBuilder()
                 .UseStartup<Startup>();
             var httpMethod = new HttpMethod("GET");
-            var route = $"/custom/route/todoitems/{todoItem.Id}";
+            var route = $"/custom/route/todo-items/{todoItem.Id}";
 
             var server = new TestServer(builder);
             var client = server.CreateClient();
@@ -194,7 +115,7 @@ public async Task CustomRouteControllers_Creates_Proper_Relationship_Links()
             var builder = new WebHostBuilder()
                 .UseStartup<Startup>();
             var httpMethod = new HttpMethod("GET");
-            var route = $"/custom/route/todoitems/{todoItem.Id}";
+            var route = $"/custom/route/todo-items/{todoItem.Id}";
 
             var server = new TestServer(builder);
             var client = server.CreateClient();
@@ -207,6 +128,7 @@ public async Task CustomRouteControllers_Creates_Proper_Relationship_Links()
             var body = await response.Content.ReadAsStringAsync();
             var deserializedBody = JsonConvert.DeserializeObject<JObject>(body);
 
+            var result =  deserializedBody["data"]["relationships"]["owner"]["links"]["related"].ToString();
             Assert.EndsWith($"{route}/owner", deserializedBody["data"]["relationships"]["owner"]["links"]["related"].ToString());
         }
     }