More types cleanup

Author: Bart Koelman

src/JsonApiDotNetCore/Extensions/TypeExtensions.cs

@@ -16,9 +16,16 @@ internal static class TypeExtensions
         /// ((IList)myList).CopyToList(targetType).
         /// </code>
         /// </summary>
-        public static IList CopyToList(this IEnumerable copyFrom, Type elementType)
+        public static IList CopyToList(this IEnumerable copyFrom, Type elementType, Converter<object, object> elementConverter = null)
         {
             Type collectionType = typeof(List<>).MakeGenericType(elementType);
+
+            if (elementConverter != null)
+            {
+                var converted = copyFrom.Cast<object>().Select(element => elementConverter(element));
+                return (IList) CopyToTypedCollection(converted, collectionType);
+            }
+
             return (IList)CopyToTypedCollection(copyFrom, collectionType);
         }
 

src/JsonApiDotNetCore/Internal/Generics/RepositoryRelationshipUpdateHelper.cs

@@ -78,9 +78,11 @@ private async Task UpdateOneToManyAsync(IIdentifiable parent, RelationshipAttrib
             }
             else
             {
+                var idType = TypeHelper.GetIdType(relationship.RightType);
+                var typedIds = relationshipIds.CopyToList(idType, stringId => TypeHelper.ConvertType(stringId, idType));
+
                 // [1, 2, 3]
-                var target = Expression.Constant(TypeHelper.ConvertListType(relationshipIds,
-                    TypeHelper.GetIdType(relationship.RightType)));
+                var target = Expression.Constant(typedIds);
                 // (Person p) => ...
                 ParameterExpression parameter = Expression.Parameter(typeof(TRelatedResource));
                 // (Person p) => p.Id

src/JsonApiDotNetCore/Internal/TypeHelper.cs

@@ -111,23 +111,6 @@ public static PropertyInfo ParseNavigationExpression<TResource>(Expression<Func<
             return (PropertyInfo)exp.Member;
         }
 
-        /// <summary>
-        /// Convert collection of query string params to Collection of concrete Type
-        /// </summary>
-        /// <param name="values">Collection like ["10","20","30"]</param>
-        /// <param name="type">Non array type. For e.g. int</param>
-        /// <returns>Collection of concrete type</returns>
-        public static IList ConvertListType(IEnumerable<string> values, Type type)
-        {
-            var list = CreateListFor(type);
-            foreach (var value in values)
-            {
-                list.Add(ConvertType(value, type));
-            }
-
-            return list;
-        }
-
         /// <summary>
         /// Creates an instance of the specified generic type
         /// </summary>
@@ -191,8 +174,7 @@ public static object CreateInstanceOfOpenType(Type openType, Type parameter, boo
         /// <param name="type">The target type</param>
         public static IList CreateListFor(Type type)
         {
-            IList list = (IList)CreateInstanceOfOpenType(typeof(List<>), type);
-            return list;
+            return (IList)CreateInstanceOfOpenType(typeof(List<>), type);
         }
 
         /// <summary>