Fixed: swapped method names

Bart Koelman · Bart Koelman · commit 15f5923df585 · 2021-11-22T12:41:24.000+01:00
diff --git a/src/JsonApiDotNetCore/Serialization/Request/Adapters/AtomicOperationObjectAdapter.cs b/src/JsonApiDotNetCore/Serialization/Request/Adapters/AtomicOperationObjectAdapter.cs
@@ -101,7 +101,7 @@ private WriteOperationKind ConvertOperationCode(AtomicOperationObject atomicOper
         private (ResourceIdentityRequirements requirements, IIdentifiable? primaryResource) ConvertRef(AtomicOperationObject atomicOperationObject,
             RequestAdapterState state)
         {
-            ResourceIdentityRequirements requirements = CreateDataRequirements(state);
+            ResourceIdentityRequirements requirements = CreateRefRequirements(state);
             IIdentifiable? primaryResource = null;
 
             AtomicReferenceResult? refResult = atomicOperationObject.Ref != null
@@ -117,14 +117,14 @@ private WriteOperationKind ConvertOperationCode(AtomicOperationObject atomicOper
 
                 ConvertRefRelationship(atomicOperationObject.Data, refResult, state);
 
-                requirements = CreateRefRequirements(refResult, requirements);
+                requirements = CreateDataRequirements(refResult, requirements);
                 primaryResource = refResult.Resource;
             }
 
             return (requirements, primaryResource);
         }
 
-        private ResourceIdentityRequirements CreateDataRequirements(RequestAdapterState state)
+        private ResourceIdentityRequirements CreateRefRequirements(RequestAdapterState state)
         {
             JsonElementConstraint? idConstraint = state.Request.WriteOperation == WriteOperationKind.CreateResource
                 ? _options.AllowClientGeneratedIds ? null : JsonElementConstraint.Forbidden
@@ -136,12 +136,12 @@ private ResourceIdentityRequirements CreateDataRequirements(RequestAdapterState
             };
         }
 
-        private static ResourceIdentityRequirements CreateRefRequirements(AtomicReferenceResult refResult, ResourceIdentityRequirements dataRequirements)
+        private static ResourceIdentityRequirements CreateDataRequirements(AtomicReferenceResult refResult, ResourceIdentityRequirements refRequirements)
         {
             return new ResourceIdentityRequirements
             {
                 ResourceType = refResult.ResourceType,
-                IdConstraint = dataRequirements.IdConstraint,
+                IdConstraint = refRequirements.IdConstraint,
                 IdValue = refResult.Resource.StringId,
                 LidValue = refResult.Resource.LocalId,
                 RelationshipName = refResult.Relationship?.PublicName

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ private WriteOperationKind ConvertOperationCode(AtomicOperationObject atomicOper`
`101`	`101`	`private (ResourceIdentityRequirements requirements, IIdentifiable? primaryResource) ConvertRef(AtomicOperationObject atomicOperationObject,`
`102`	`102`	`RequestAdapterState state)`
`103`	`103`	`{`
`104`		`- ResourceIdentityRequirements requirements = CreateDataRequirements(state);`
	`104`	`+ ResourceIdentityRequirements requirements = CreateRefRequirements(state);`
`105`	`105`	`IIdentifiable? primaryResource = null;`
`106`	`106`
`107`	`107`	`AtomicReferenceResult? refResult = atomicOperationObject.Ref != null`
`@@ -117,14 +117,14 @@ private WriteOperationKind ConvertOperationCode(AtomicOperationObject atomicOper`
`117`	`117`
`118`	`118`	`ConvertRefRelationship(atomicOperationObject.Data, refResult, state);`
`119`	`119`
`120`		`- requirements = CreateRefRequirements(refResult, requirements);`
	`120`	`+ requirements = CreateDataRequirements(refResult, requirements);`
`121`	`121`	`primaryResource = refResult.Resource;`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`return (requirements, primaryResource);`
`125`	`125`	`}`
`126`	`126`
`127`		`- private ResourceIdentityRequirements CreateDataRequirements(RequestAdapterState state)`
	`127`	`+ private ResourceIdentityRequirements CreateRefRequirements(RequestAdapterState state)`
`128`	`128`	`{`
`129`	`129`	`JsonElementConstraint? idConstraint = state.Request.WriteOperation == WriteOperationKind.CreateResource`
`130`	`130`	`? _options.AllowClientGeneratedIds ? null : JsonElementConstraint.Forbidden`
`@@ -136,12 +136,12 @@ private ResourceIdentityRequirements CreateDataRequirements(RequestAdapterState`
`136`	`136`	`};`
`137`	`137`	`}`
`138`	`138`
`139`		`- private static ResourceIdentityRequirements CreateRefRequirements(AtomicReferenceResult refResult, ResourceIdentityRequirements dataRequirements)`
	`139`	`+ private static ResourceIdentityRequirements CreateDataRequirements(AtomicReferenceResult refResult, ResourceIdentityRequirements refRequirements)`
`140`	`140`	`{`
`141`	`141`	`return new ResourceIdentityRequirements`
`142`	`142`	`{`
`143`	`143`	`ResourceType = refResult.ResourceType,`
`144`		`- IdConstraint = dataRequirements.IdConstraint,`
	`144`	`+ IdConstraint = refRequirements.IdConstraint,`
`145`	`145`	`IdValue = refResult.Resource.StringId,`
`146`	`146`	`LidValue = refResult.Resource.LocalId,`
`147`	`147`	`RelationshipName = refResult.Relationship?.PublicName`