Added tests for using ActionResult without [ApiController]

Author: Bart Koelman

src/Examples/JsonApiDotNetCoreExample/Controllers/TodoItemsTestController.cs

@@ -1,6 +1,9 @@
+using System.Net;
+using System.Threading.Tasks;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Controllers;
 using JsonApiDotNetCore.Models;
+using JsonApiDotNetCore.Models.JsonApiDocuments;
 using JsonApiDotNetCore.Services;
 using JsonApiDotNetCoreExample.Models;
 using Microsoft.AspNetCore.Mvc;
@@ -9,7 +12,7 @@
 namespace JsonApiDotNetCoreExample.Controllers
 {
     public abstract class AbstractTodoItemsController<T> 
-    : JsonApiController<T> where T : class, IIdentifiable<int>
+    : BaseJsonApiController<T> where T : class, IIdentifiable<int>
     {
         protected AbstractTodoItemsController(
             IJsonApiOptions jsonApiOptions,
@@ -19,6 +22,7 @@ protected AbstractTodoItemsController(
         { }
     }
 
+    [DisableRoutingConvention]
     [Route("/abstract")]
     public class TodoItemsTestController : AbstractTodoItemsController<TodoItem>
     {
@@ -28,5 +32,49 @@ public TodoItemsTestController(
             IResourceService<TodoItem> service)
             : base(jsonApiOptions, loggerFactory, service)
         { }
+
+        [HttpGet]
+        public override async Task<IActionResult> GetAsync() => await base.GetAsync();
+
+        [HttpGet("{id}")]
+        public override async Task<IActionResult> GetAsync(int id) => await base.GetAsync(id);
+
+        [HttpGet("{id}/relationships/{relationshipName}")]
+        public override async Task<IActionResult> GetRelationshipsAsync(int id, string relationshipName)
+            => await base.GetRelationshipsAsync(id, relationshipName);
+
+        [HttpGet("{id}/{relationshipName}")]
+        public override async Task<IActionResult> GetRelationshipAsync(int id, string relationshipName)
+            => await base.GetRelationshipAsync(id, relationshipName);
+
+        [HttpPost]
+        public override async Task<IActionResult> PostAsync(TodoItem entity)
+        {
+            await Task.Yield();
+
+            return NotFound(new Error(HttpStatusCode.NotFound)
+            {
+                Title = "NotFound ActionResult with explicit error object."
+            });
+        }
+
+        [HttpPatch("{id}")]
+        public override async Task<IActionResult> PatchAsync(int id, [FromBody] TodoItem entity)
+        {
+            return await base.PatchAsync(id, entity);
+        }
+
+        [HttpPatch("{id}/relationships/{relationshipName}")]
+        public override async Task<IActionResult> PatchRelationshipsAsync(
+            int id, string relationshipName, [FromBody] object relationships)
+            => await base.PatchRelationshipsAsync(id, relationshipName, relationships);
+
+        [HttpDelete("{id}")]
+        public override async Task<IActionResult> DeleteAsync(int id)
+        {
+            await Task.Yield();
+
+            return NotFound();
+        }
     }
 }

test/JsonApiDotNetCoreExampleTests/Acceptance/ActionResultTests.cs

@@ -0,0 +1,80 @@
+using System.Collections.Generic;
+using System.Net;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using System.Threading.Tasks;
+using JsonApiDotNetCore.Models.JsonApiDocuments;
+using JsonApiDotNetCoreExample;
+using Newtonsoft.Json;
+using Xunit;
+
+namespace JsonApiDotNetCoreExampleTests.Acceptance
+{
+    [Collection("WebHostCollection")]
+    public sealed class ActionResultTests
+    {
+        private readonly TestFixture<Startup> _fixture;
+
+        public ActionResultTests(TestFixture<Startup> fixture)
+        {
+            _fixture = fixture;
+        }
+
+        [Fact]
+        public async Task ActionResult_With_Error_Object_Is_Converted_To_Error_Collection()
+        {
+            // Arrange
+            var route = "/abstract";
+            var request = new HttpRequestMessage(HttpMethod.Post, route);
+            var content = new
+            {
+                data = new
+                {
+                    type = "todoItems",
+                    id = 1,
+                    attributes = new Dictionary<string, object>
+                    {
+                        {"ordinal", 1}
+                    }
+                }
+            };
+
+            request.Content = new StringContent(JsonConvert.SerializeObject(content));
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/vnd.api+json");
+
+            // Act
+            var response = await _fixture.Client.SendAsync(request);
+
+            // Assert
+            var body = await response.Content.ReadAsStringAsync();
+            Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
+
+            var errorDocument = JsonConvert.DeserializeObject<ErrorDocument>(body);
+            Assert.Single(errorDocument.Errors);
+            Assert.Equal(HttpStatusCode.NotFound, errorDocument.Errors[0].StatusCode);
+            Assert.Equal("NotFound ActionResult with explicit error object.", errorDocument.Errors[0].Title);
+            Assert.Null(errorDocument.Errors[0].Detail);
+        }
+
+        [Fact]
+        public async Task Empty_ActionResult_Is_Converted_To_Error_Collection()
+        {
+            // Arrange
+            var route = "/abstract/123";
+            var request = new HttpRequestMessage(HttpMethod.Delete, route);
+
+            // Act
+            var response = await _fixture.Client.SendAsync(request);
+
+            // Assert
+            var body = await response.Content.ReadAsStringAsync();
+            Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
+
+            var errorDocument = JsonConvert.DeserializeObject<ErrorDocument>(body);
+            Assert.Single(errorDocument.Errors);
+            Assert.Equal(HttpStatusCode.NotFound, errorDocument.Errors[0].StatusCode);
+            Assert.Equal("NotFound", errorDocument.Errors[0].Title);
+            Assert.Null(errorDocument.Errors[0].Detail);
+        }
+    }
+}