feat(AttrAttribute): add isSortable and isFilterable

Author: jaredcnance

src/JsonApiDotNetCore/AssemblyInfo.cs

@@ -0,0 +1,4 @@
+using System.Runtime.CompilerServices;
+[assembly:InternalsVisibleTo("UnitTests")]
+[assembly:InternalsVisibleTo("JsonApiDotNetCoreExampleTests")]
+[assembly:InternalsVisibleTo("NoEntityFrameworkTests")]

src/JsonApiDotNetCore/Internal/Query/AttrFilterQuery.cs

@@ -17,14 +17,20 @@ public AttrFilterQuery(
 
             var attribute = GetAttribute(filterQuery.Attribute);
 
-            FilteredAttribute = attribute ?? throw new JsonApiException(400, $"'{filterQuery.Attribute}' is not a valid attribute.");
+            if(attribute == null)
+                throw new JsonApiException(400, $"'{filterQuery.Attribute}' is not a valid attribute.");
+
+            if(attribute.IsFilterable == false)
+                throw new JsonApiException(400, $"Filter is not allowed for attribute '{attribute.PublicAttributeName}'.");
+
+            FilteredAttribute = attribute;
             PropertyValue = filterQuery.Value;
             FilterOperation = GetFilterOperation(filterQuery.Operation);
         }
 
-        public AttrAttribute FilteredAttribute { get; set; }
-        public string PropertyValue { get; set; }
-        public FilterOperations FilterOperation { get; set; }
+        public AttrAttribute FilteredAttribute { get; }
+        public string PropertyValue { get; }
+        public FilterOperations FilterOperation { get; }
 
         private AttrAttribute GetAttribute(string attribute) =>  
             _jsonApiContext.RequestEntity.Attributes.FirstOrDefault(

src/JsonApiDotNetCore/Internal/Query/RelatedAttrFilterQuery.cs

@@ -19,12 +19,18 @@ public RelatedAttrFilterQuery(
 
             var relationship = GetRelationship(relationshipArray[0]);
             if (relationship == null)
-                throw new JsonApiException(400, $"{relationshipArray[0]} is not a valid relationship.");
+                throw new JsonApiException(400, $"{relationshipArray[1]} is not a valid relationship on {relationshipArray[0]}.");
 
             var attribute = GetAttribute(relationship, relationshipArray[1]);
+            
+            if(attribute == null)
+                throw new JsonApiException(400, $"'{filterQuery.Attribute}' is not a valid attribute.");
+
+            if(attribute.IsFilterable == false)
+                throw new JsonApiException(400, $"Filter is not allowed for attribute '{attribute.PublicAttributeName}'.");
 
             FilteredRelationship = relationship;
-            FilteredAttribute = attribute ?? throw new JsonApiException(400, $"{relationshipArray[1]} is not a valid attribute on {relationshipArray[0]}.");
+            FilteredAttribute = attribute;
             PropertyValue = filterQuery.Value;
             FilterOperation = GetFilterOperation(filterQuery.Operation);
         }

src/JsonApiDotNetCore/Models/AttrAttribute.cs

@@ -1,27 +1,30 @@
 using System;
-using System.Reflection;
 using JsonApiDotNetCore.Internal;
 
 namespace JsonApiDotNetCore.Models
 {
     public class AttrAttribute : Attribute
     {
-        public AttrAttribute(string publicName, bool isImmutable = false)
+        public AttrAttribute(string publicName, bool isImmutable = false, bool isFilterable = true, bool isSortable = true)
         {
             PublicAttributeName = publicName;
             IsImmutable = isImmutable;
+            IsFilterable = isFilterable;
+            IsSortable = isSortable;
         }
 
-        public AttrAttribute(string publicName, string internalName, bool isImmutable = false)
+        internal AttrAttribute(string publicName, string internalName, bool isImmutable = false)
         {
             PublicAttributeName = publicName;
             InternalAttributeName = internalName;
             IsImmutable = isImmutable;
         }
 
-        public string PublicAttributeName { get; set; }
-        public string InternalAttributeName { get; set; }
-        public bool IsImmutable { get; set; }
+        public string PublicAttributeName { get; }
+        public string InternalAttributeName { get; }
+        public bool IsImmutable { get; }
+        public bool IsFilterable { get; }
+        public bool IsSortable { get; }
 
         public object GetValue(object entity)
         {

src/JsonApiDotNetCore/Models/RelationshipAttribute.cs

@@ -10,12 +10,12 @@ protected RelationshipAttribute(string publicName, Link documentLinks)
             DocumentLinks = documentLinks;
         }
 
-        public string PublicRelationshipName { get; set; }
-        public string InternalRelationshipName { get; set; }
-        public Type Type { get; set; }
+        public string PublicRelationshipName { get; }
+        public string InternalRelationshipName { get; }
+        public Type Type { get; }
         public bool IsHasMany => GetType() == typeof(HasManyAttribute);
         public bool IsHasOne => GetType() == typeof(HasOneAttribute);
-        public Link DocumentLinks { get; set; } = Link.All;
+        public Link DocumentLinks { get; } = Link.All;
 
         public abstract void SetValue(object entity, object newValue);
 

src/JsonApiDotNetCore/Services/QueryParser.cs

@@ -159,6 +159,9 @@ protected virtual List<SortQuery> ParseSortParameters(string value)
 
                 var attribute = GetAttribute(propertyName);
 
+                if(attribute.IsSortable == false)
+                    throw new JsonApiException(400, $"Sort is not allowed for attribute '{attribute.PublicAttributeName}'.");
+
                 sortParameters.Add(new SortQuery(direction, attribute));
             };