Skip to content

Commit 5fac607

Browse files
committed
Revise strategy for vulnerable transitive dependency on Microsoft.Extensions.Caching.Memory on net8.0
1 parent 513558f commit 5fac607

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

package-versions.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,18 @@
2020
<PropertyGroup Condition="'$(TargetFramework)' == 'net10.0'">
2121
<!-- Non-published dependencies (these are safe to update, won't cause a breaking change) -->
2222
<AspNetCoreVersion>10.0.*</AspNetCoreVersion>
23+
<MicrosoftExtensionsCachingMemoryVersion>10.0.*</MicrosoftExtensionsCachingMemoryVersion>
2324
</PropertyGroup>
2425

2526
<PropertyGroup Condition="'$(TargetFramework)' == 'net9.0'">
2627
<!-- Non-published dependencies (these are safe to update, won't cause a breaking change) -->
2728
<AspNetCoreVersion>9.0.*</AspNetCoreVersion>
29+
<MicrosoftExtensionsCachingMemoryVersion>9.0.*</MicrosoftExtensionsCachingMemoryVersion>
2830
</PropertyGroup>
2931

3032
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
3133
<!-- Non-published dependencies (these are safe to update, won't cause a breaking change) -->
3234
<AspNetCoreVersion>8.0.*</AspNetCoreVersion>
35+
<MicrosoftExtensionsCachingMemoryVersion>8.0.*</MicrosoftExtensionsCachingMemoryVersion>
3336
</PropertyGroup>
3437
</Project>

src/JsonApiDotNetCore.MongoDb/JsonApiDotNetCore.MongoDb.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@
3232

3333
<ItemGroup>
3434
<PackageReference Include="JsonApiDotNetCore" Version="$(JsonApiDotNetCoreFrozenVersion)" />
35-
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" Condition="'$(TargetFramework)' == 'net8.0'" NoWarn="$(NoWarn);NU1510">
36-
<!--
37-
Microsoft.EntityFrameworkCore 8.0.0 depends on Microsoft.Extensions.Caching.Memory 8.0.0, which is vulnerable.
38-
This package reference silences the vulnerability warning and suppresses the NU1510 warning that the dependency will not appear in our NuGet package.
39-
-->
40-
</PackageReference>
4135
<PackageReference Include="MongoDB.Driver" Version="$(MongoDBDriverFrozenVersion)" />
4236
<PackageReference Include="SauceControl.InheritDoc" Version="$(InheritDocVersion)" PrivateAssets="All" />
4337
</ItemGroup>

test/JsonApiDotNetCoreMongoDbTests/JsonApiDotNetCoreMongoDbTests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<PackageReference Include="coverlet.collector" Version="$(CoverletVersion)" PrivateAssets="All" />
1515
<PackageReference Include="GitHubActionsTestLogger" Version="$(GitHubActionsTestLoggerVersion)" PrivateAssets="All" />
1616
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(AspNetCoreVersion)" />
17+
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="$(MicrosoftExtensionsCachingMemoryVersion)" />
1718
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(TestSdkVersion)" />
1819
</ItemGroup>
1920
</Project>

test/TestBuildingBlocks/TestBuildingBlocks.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
44
</PropertyGroup>
@@ -16,6 +16,7 @@
1616
<PackageReference Include="GitHubActionsTestLogger" Version="$(GitHubActionsTestLoggerVersion)" PrivateAssets="All" />
1717
<PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVersion)" />
1818
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(AspNetCoreVersion)" />
19+
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="$(MicrosoftExtensionsCachingMemoryVersion)" />
1920
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(TestSdkVersion)" />
2021
<PackageReference Include="MongoDB.Driver" Version="$(MongoDBDriverVersion)" />
2122
<PackageReference Include="xunit" Version="$(XunitVersion)" />

0 commit comments

Comments
 (0)