Skip to content

Commit a9cec34

Browse files
committed
remove positioning style in controller, update test
1 parent 5944862 commit a9cec34

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

__tests__/ParallaxController.test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ describe('Expect the ParallaxController', () => {
5050
},
5151
};
5252
const element = instance.createElement(options);
53-
const expectedElInner = document.createElement('div');
54-
expectedElInner.style.position = 'relative';
5553

5654
const expectedElement = {
5755
attributes: {
@@ -65,7 +63,7 @@ describe('Expect the ParallaxController', () => {
6563
yMaxPx: 0,
6664
yMinPx: 0,
6765
},
68-
elInner: expectedElInner,
66+
elInner: document.createElement('div'),
6967
elOuter: document.createElement('div'),
7068
id: 1,
7169
offsets: {

src/libs/ParallaxController.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,9 @@ function ParallaxController() {
295295

296296
// Apply styles
297297
const el = element.elInner;
298-
el.style.cssText = `position:relative;
299-
transform:translate3d(${offsets.x.value}${offsets.x.unit}, ${offsets.y.value}${offsets.y.unit}, 0)`;
298+
299+
// prettier-ignore
300+
el.style.transform = `translate3d(${offsets.x.value}${offsets.x.unit}, ${offsets.y.value}${offsets.y.unit}, 0)`;
300301
}
301302

302303
/**
@@ -305,8 +306,7 @@ function ParallaxController() {
305306
*/
306307
function _resetStyles(element) {
307308
const el = element.elInner;
308-
el.style.cssText = `position:relative;
309-
transform:translate3d(0, 0, 0)`;
309+
el.style.transform = '';
310310
}
311311

312312
/**
@@ -407,7 +407,7 @@ ParallaxController.init = function() {
407407
);
408408
}
409409

410-
// Keep global reference for legacy versions >= 1.0.0
410+
// Keep global reference for legacy versions <= 1.1.0
411411

412412
if (hasWindow && !window.ParallaxController) {
413413
window.ParallaxController = new ParallaxController();

0 commit comments

Comments
 (0)