Bugfix regarding styles

xdev1 · xdev1 · commit 5ce17e4b1349 · 2021-08-26T15:54:43.000+02:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "js-element",
-  "version": "0.0.205",
+  "version": "0.0.206",
   "description": "",
   "license": "LGPL-3.0",
   "main": "./index.js",
diff --git a/src/main/js-element.ts b/src/main/js-element.ts
@@ -179,12 +179,16 @@ class BaseElement extends HTMLElement {
     let styles = elemConfigByClass.get(this.constructor)!.styles
 
     if (typeof styles !== 'string') {
-      styles = typeof styles === 'function' ? styles() : (styles = '')
+      styles = typeof styles === 'function' ? styles() : styles
 
       if (Array.isArray(styles)) {
         styles = styles.map((it) => it.trim()).join('\n\n/*******/\n\n')
       }
 
+      if (!styles) {
+        styles = ''
+      }
+
       elemConfigByClass.get(this.constructor)!.styles = styles
     }
 

Original file line number	Diff line number	Diff line change
`@@ -179,12 +179,16 @@ class BaseElement extends HTMLElement {`
`179`	`179`	`let styles = elemConfigByClass.get(this.constructor)!.styles`
`180`	`180`
`181`	`181`	`if (typeof styles !== 'string') {`
`182`		`- styles = typeof styles === 'function' ? styles() : (styles = '')`
	`182`	`+ styles = typeof styles === 'function' ? styles() : styles`
`183`	`183`
`184`	`184`	`if (Array.isArray(styles)) {`
`185`	`185`	`styles = styles.map((it) => it.trim()).join('\n\n/*******/\n\n')`
`186`	`186`	`}`
`187`	`187`
	`188`	`+ if (!styles) {`
	`189`	`+ styles = ''`
	`190`	`+ }`
	`191`	`+`
`188`	`192`	`elemConfigByClass.get(this.constructor)!.styles = styles`
`189`	`193`	`}`
`190`	`194`