we (still) should not break older JRubies we test against on CI (in 0.9.x)

kares · kares · commit 2e6f6a7f5887 · 2017-07-26T13:29:35.000+02:00
diff --git a/src/main/java/org/jruby/ext/openssl/Random.java b/src/main/java/org/jruby/ext/openssl/Random.java
@@ -68,6 +68,9 @@ private static Holder createHolderImpl() {
         if (HOLDER_TYPE.equals("strong")) {
             return new StrongHolder();
         }
+        if (ThreadLocalHolder.secureRandomField == null) {
+            return new SharedHolder(); // fall-back on (older) JRuby <= 1.7.4
+        }
         return new ThreadLocalHolder();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,9 @@ private static Holder createHolderImpl() {`
`68`	`68`	`if (HOLDER_TYPE.equals("strong")) {`
`69`	`69`	`return new StrongHolder();`
`70`	`70`	`}`
	`71`	`+ if (ThreadLocalHolder.secureRandomField == null) {`
	`72`	`+ return new SharedHolder(); // fall-back on (older) JRuby <= 1.7.4`
	`73`	`+ }`
`71`	`74`	`return new ThreadLocalHolder();`
`72`	`75`	`}`
`73`	`76`