Skip to content

Commit d292394

Browse files
authored
require an explicit DBS for release:do
1 parent de16bfb commit d292394

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

Rakefile

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@ end
9696

9797
desc "Releasing AR-JDBC gems (use NOOP=true to disable gem pushing)"
9898
task 'release:do' do
99+
if !ENV["DBS"] || ENV["DBS"].strip.empty?
100+
puts "you must explicitly provide a DBS env var when calling release:do. An empty one will not default to 'all' " \
101+
"for this command\n\n"
102+
invalid_dbs!
103+
end
104+
99105
Rake::Task['build'].invoke
100106
Rake::Task['build:adapters'].invoke
101107

@@ -135,8 +141,9 @@ def invalid_dbs!
135141
end
136142

137143
def make_db_list
138-
ENV["DBS"] = "mysql,postgresql,sqlite3" if ENV["DBS"] == "all" || ENV["DBS"].nil? || ENV["DBS"].strip.empty?
139-
requested = ENV["DBS"].split(",").map(&:strip).reject(&:empty?).map(&:downcase)
144+
env_dbs = ENV["DBS"]
145+
env_dbs = "mysql,postgresql,sqlite3" if env_dbs == "all" || env_dbs.nil? || env_dbs.strip.empty?
146+
requested = env_dbs.split(",").map(&:strip).reject(&:empty?).map(&:downcase)
140147
invalid_dbs! unless requested.size > 0 && requested.size <= 3 && requested == requested.uniq
141148

142149
canonical = requested.map do |name|

0 commit comments

Comments
 (0)