Postgres, skip jndi test and and delete some dedundant unit tests

Author: JesseChavez

test/db/postgresql/unit_test.rb

@@ -5,6 +5,7 @@ class PostgresUnitTest < Test::Unit::TestCase
   context 'connection' do
 
     test 'jndi configuration' do
+      skip "postgresql_connection was removed, find ways to integrate jndi if needed since AR 7.1 & 7.2 changed so much"
       connection_handler = connection_handler_stub
 
       config = { :jndi => 'jdbc/TestDS' }
@@ -31,72 +32,4 @@ def connection.database_product; "PostgreSQL 9.6.8" end
     ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.any_instance.stubs(:initialize_type_map)
     ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.new(connection, nil, {})
   end
-
-end if defined? JRUBY_VERSION
-
-class PostgresActiveSchemaUnitTest < Test::Unit::TestCase
-
-  setup do
-    connection = ActiveRecord::Base.connection
-    def connection.execute(sql, name = nil); sql; end
-  end
-
-  teardown do
-    connection = ActiveRecord::Base.connection
-    meta_class = class << connection; self; end
-    meta_class.send :remove_method, :execute
-  end
-
-  def test_add_index
-    # add_index calls data_source_exists? which can't work since execute is stubbed
-    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:define_method, :data_source_exists?) do |_name|
-      true
-    end
-    redefined_data_source_check = true
-
-    # add_index calls index_name_exists? which can't work since execute is stubbed
-    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:define_method, :index_name_exists?) do |*|
-      false
-    end
-    redefined_index_check = true
-
-    expected = %(CREATE UNIQUE INDEX "index_people_on_last_name" ON "people" ("last_name") WHERE state = 'active')
-    assert_equal expected, add_index(:people, :last_name, :unique => true, :where => "state = 'active'")
-
-    expected = %(CREATE INDEX CONCURRENTLY "index_people_on_last_name" ON "people" ("last_name"))
-    assert_equal expected, add_index(:people, :last_name, :algorithm => :concurrently)
-
-    %w(gin gist hash btree).each do |type|
-      expected = %(CREATE INDEX "index_people_on_last_name" ON "people" USING #{type} ("last_name"))
-      assert_equal expected, add_index(:people, :last_name, :using => type)
-
-      expected = %(CREATE INDEX CONCURRENTLY "index_people_on_last_name" ON "people" USING #{type} ("last_name"))
-      assert_equal expected, add_index(:people, :last_name, :using => type, :algorithm => :concurrently)
-    end
-
-    assert_raise ArgumentError do
-      add_index(:people, :last_name, :algorithm => :copy)
-    end
-    expected = %(CREATE UNIQUE INDEX "index_people_on_last_name" ON "people" USING gist ("last_name"))
-    assert_equal expected, add_index(:people, :last_name, :unique => true, :using => :gist)
-
-    expected = %(CREATE UNIQUE INDEX "index_people_on_last_name" ON "people" USING gist ("last_name") WHERE state = 'active')
-    assert_equal expected, add_index(:people, :last_name, :unique => true, :where => "state = 'active'", :using => :gist)
-
-  ensure
-    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:remove_method, :data_source_exists?) if redefined_data_source_check
-    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:remove_method, :index_name_exists?) if redefined_index_check
-  end
-
-  def test_rename_index
-    expected = "ALTER INDEX \"last_name_index\" RENAME TO \"name_index\""
-    assert_equal expected, rename_index(:people, :last_name_index, :name_index)
-  end
-
-  private
-
-  def method_missing(method_symbol, ...)
-    ActiveRecord::Base.connection.send(method_symbol, ...)
-  end
-
 end