fix(reporter): log a more descriptive test URL in the reporter

- Also update all submodules for tests

Author: timmywil

lib/buildTestUrl.js

@@ -1,9 +1,8 @@
-import { generateModuleId } from "./generateHash.js";
-
 export function buildTestUrl( {
 	baseUrl,
 	browserstack,
 	flags,
+	flagHook,
 	run,
 	jsdom,
 	port,
@@ -19,9 +18,9 @@ export function buildTestUrl( {
 	for ( const flag of allFlags ) {
 		const [ key, value ] = flag.split( "=" );
 
-		// Special handling for the module flag
-		if ( key === "module" ) {
-			query.append( "moduleId", generateModuleId( value ) );
+		// Allow for custom flag handling
+		if ( flagHook ) {
+			query.append.apply( query, flagHook( key, value ) );
 		} else {
 			query.append( key, value ?? "true" );
 		}
@@ -38,5 +37,7 @@ export function buildTestUrl( {
 	// BrowserStack supplies a custom domain for local testing,
 	// which is especially necessary for iOS testing.
 	const host = browserstack ? "bs-local.com" : "localhost";
-	return `http://${ host }:${ port }${ baseUrl }${ testUrl }?${ query }`;
+	return `http://${ host }:${ port }${ baseUrl }${ testUrl }${
+		query.size > 0 ? `?${ query }` : ""
+	}`;
 }

reporter.js

@@ -113,10 +113,10 @@ export function reportTest( test, { fullBrowser, id } ) {
 	}
 }
 
-export function reportEnd( result, { fullBrowser, id, url } ) {
+export function reportEnd( result, { descriptiveUrl, fullBrowser, id } ) {
 	console.log(
 		`\n\nTests finished in ${ prettyMs( result.runtime ) } ` +
-			`at ${ chalk.yellow( url ) } ` +
+			`at ${ chalk.yellow( descriptiveUrl ) } ` +
 			`in ${ chalk.yellow( fullBrowser ) } (${ chalk.bold( id ) })...`
 	);
 	console.log(

run.js

@@ -6,7 +6,7 @@ import { localTunnel } from "./browserstack/local.js";
 import { reportEnd, reportTest } from "./reporter.js";
 import { createTestServer } from "./createTestServer.js";
 import { buildTestUrl } from "./lib/buildTestUrl.js";
-import { generateHash } from "./lib/generateHash.js";
+import { generateHash, generateModuleId } from "./lib/generateHash.js";
 import { getBrowserString } from "./lib/getBrowserString.js";
 import { cleanupAllBrowsers, touchBrowser } from "./browsers.js";
 import {
@@ -27,6 +27,7 @@ export async function run( {
 	concurrency,
 	debug,
 	flag: flags = [],
+	flagHook = defaultFlagHook,
 	hardRetries,
 	headless,
 	middleware = [],
@@ -248,15 +249,21 @@ export async function run( {
 			`${ hashValue }-${ run }-${ testUrl }-${ fullBrowser }`
 		);
 
-		const url = buildTestUrl( {
+		const urlOptions = {
 			baseUrl,
 			browserstack,
 			flags,
 			run,
 			jsdom: browser.browser === "jsdom",
 			port,
-			reportId,
 			testUrl
+		};
+
+		const descriptiveUrl = buildTestUrl( urlOptions );
+		const url = buildTestUrl( {
+			...urlOptions,
+			flagHook,
+			reportId
 		} );
 
 		const options = {
@@ -274,8 +281,9 @@ export async function run( {
 			verbose
 		};
 
-		reports[ reportId ] = {
+		const report = {
 			browser,
+			descriptiveUrl,
 			flags,
 			fullBrowser,
 			headless,
@@ -285,6 +293,8 @@ export async function run( {
 			url
 		};
 
+		reports[ reportId ] = report;
+
 		addRun( url, browser, options );
 	}
 
@@ -363,3 +373,12 @@ export async function run( {
 		}
 	}
 }
+
+function defaultFlagHook( key, value ) {
+
+	// Convert module flag to module ID
+	if ( key === "module" ) {
+		return [ "moduleId", generateModuleId( value ) ];
+	}
+	return [ key, value ];
+}