Skip to content

Commit b7c3589

Browse files
committed
cleaned up the code
1 parent 03d984b commit b7c3589

File tree

3 files changed

+36
-37
lines changed

3 files changed

+36
-37
lines changed

ChangeLog.markdown

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
11
# Mouse Wheel ChangeLog
22

3-
# 3.0.1
43

5-
* Normalize event.currentTarget
4+
# 3.0.2
5+
66
* Fixed delta being opposite value in latest Opera
77
* No longer fix pageX, pageY for older mozilla browsers
88
* Removed browser detection
9+
* Cleaned up the code
10+
11+
12+
# 3.0.1
13+
14+
* Bad release... creating a new release due to plugins.jquery.com issue :(
915

1016

1117
# 3.0

jquery.mousewheel.js

Lines changed: 27 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,53 +4,30 @@
44
* Thanks to: http://adomas.org/javascript-mouse-wheel/ for some pointers.
55
* Thanks to: Mathias Bank(http://www.mathias-bank.de) for a scope bug fix.
66
*
7-
* Version: 3.0.1
7+
* Version: 3.0.2
88
*
99
* Requires: 1.2.2+
1010
*/
1111

1212
(function($) {
1313

14+
var types = ['DOMMouseScroll', 'mousewheel'];
15+
1416
$.event.special.mousewheel = {
1517
setup: function() {
16-
var handler = $.event.special.mousewheel.handler;
17-
18-
if ( this.addEventListener ) {
19-
this.addEventListener( 'DOMMouseScroll', handler, false);
20-
this.addEventListener( 'mousewheel', handler, false);
21-
} else
18+
if ( this.addEventListener )
19+
for ( var i=types.length; i; )
20+
this.addEventListener( types[--i], handler, false );
21+
else
2222
this.onmousewheel = handler;
2323
},
2424

2525
teardown: function() {
26-
var handler = $.event.special.mousewheel.handler;
27-
28-
if ( this.removeEventListener ) {
29-
this.removeEventListener( 'DOMMouseScroll', handler, false);
30-
this.removeEventListener( 'mousewheel', handler, false);
31-
} else
26+
if ( this.removeEventListener )
27+
for ( var i=types.length; i; )
28+
this.removeEventListener( types[--i], handler, false );
29+
else
3230
this.onmousewheel = null;
33-
},
34-
35-
handler: function(event) {
36-
var args = [].slice.call( arguments, 1 );
37-
38-
event = $.event.fix(event || window.event);
39-
event.currentTarget = this;
40-
var delta = 0, returnValue = true;
41-
42-
if ( event.wheelDelta ) delta = event.wheelDelta/120;
43-
if ( event.detail ) delta = -event.detail/3;
44-
45-
event.data = event.data || {};
46-
event.type = "mousewheel";
47-
48-
// Add delta to the front of the arguments
49-
args.unshift(delta);
50-
// Add event to the front of the arguments
51-
args.unshift(event);
52-
53-
return $.event.handle.apply(this, args);
5431
}
5532
};
5633

@@ -64,4 +41,20 @@ $.fn.extend({
6441
}
6542
});
6643

44+
45+
function handler(event) {
46+
var args = [].slice.call( arguments, 1 ), delta = 0, returnValue = true;
47+
48+
event = $.event.fix(event || window.event);
49+
event.type = "mousewheel";
50+
51+
if ( event.wheelDelta ) delta = event.wheelDelta/120;
52+
if ( event.detail ) delta = -event.detail/3;
53+
54+
// Add events and delta to the front of the arguments
55+
args.unshift(event, delta);
56+
57+
return $.event.handle.apply(this, args);
58+
}
59+
6760
})(jQuery);

test/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
});
166166

167167
function log(msg) {
168-
$('#logger').append(msg+'<br>');
168+
$('#logger').append(msg+'<br>').scrollTop(999999);
169169
};
170170
});
171171
</script>

0 commit comments

Comments
 (0)