Merge branch 'master' into develop

Author: kevindb

.circleci/config.yml

@@ -0,0 +1,50 @@
+# Javascript Node CircleCI 2.0 configuration file
+#
+# Check https://circleci.com/docs/2.0/language-javascript/ for more details
+#
+version: 2
+jobs:
+  build:
+    docker:
+      # specify the version you desire here
+      - image: circleci/node:8
+
+      # Specify service dependencies here if necessary
+      # CircleCI maintains a library of pre-built images
+      # documented at https://circleci.com/docs/2.0/circleci-images/
+      # - image: circleci/mongo:3.4.4
+
+    working_directory: ~/repo
+
+    steps:
+      - checkout
+
+      - run:
+          name: "Checking Versions"
+          command: |
+            node --version
+            npm --version
+
+      - run:
+          name: update-npm
+          command: 'sudo npm install -g npm@latest'
+
+      # Download and cache dependencies
+      - restore_cache:
+          key: dependency-cache-{{ checksum "package.json" }}
+
+      - run: npm install
+
+      - save_cache:
+          key: dependency-cache-{{ checksum "package.json" }}
+          paths:
+            - ./node_modules
+
+      - run:
+          name: "Checking Versions"
+          command: |
+            node --version
+            npm --version
+
+      # run tests!
+      - run: grunt test

.eslintrc.js

@@ -24,7 +24,7 @@ module.exports = {
 			"warn",
 			"always"
 		],
-		"brace-style":  [
+		"brace-style": [
 			"error",
 			"1tbs"
 		],
@@ -33,7 +33,6 @@ module.exports = {
 			"warn",
 			{ "properties": "always" }
 		],
-		"capitalized-comments": "off",
 		"class-methods-use-this": "error",
 		"comma-dangle": [
 			"error",
@@ -47,8 +46,16 @@ module.exports = {
 		],
 		"computed-property-spacing": "error",
 		"consistent-return": "error",
-		"consistent-this": "error",
-		"curly": "error",
+		"consistent-this": [
+			"error",
+			"that",
+			"outerThis",
+			"self"
+		],
+		"curly": [
+			"error",
+			"all"
+		],
 		"default-case": "error",
 		"dot-location": [
 			"error",
@@ -59,24 +66,14 @@ module.exports = {
 		"eqeqeq": "error",
 		"func-call-spacing": "error",
 		"func-name-matching": "error",
-		"func-names": "off",
-		"func-style": "off",
-		"generator-star-spacing": "error",
-		"global-require": "error",
-		"guard-for-in": "warn",
-		"handle-callback-err": "error",
-		"id-blacklist": "error",
 		"id-length": [
 			"warn",
 			{ "exceptions": ["$","e","i","j"] }
 		],
-		"id-match": "error",
 		"indent": [
 			"error",
 			"tab"
 		],
-		"init-declarations": "off",
-		"jsx-quotes": "error",
 		"key-spacing": [
 			"warn", {
 				"singleLine": {
@@ -91,16 +88,11 @@ module.exports = {
 			}
 		],
 		"keyword-spacing": "error",
-		"line-comment-position": "off",
 		"linebreak-style": [
 			"warn",
 			"unix"
 		],
-		"lines-around-comment": "off",
-		"lines-around-directive": "off",
 		"max-depth": "warn",
-		"max-len": "off",
-		"max-lines": "off",
 		"max-nested-callbacks": "error",
 		"max-params": [
 			"warn",
@@ -119,8 +111,6 @@ module.exports = {
 			"never"
 		],
 		"new-parens": "error",
-		"newline-after-var": "warn",
-		"newline-before-return": "error",
 		"newline-per-chained-call": [
 			"warn",
 			{ "ignoreChainWithDepth": 3 }
@@ -130,13 +120,15 @@ module.exports = {
 		"no-await-in-loop": "error",
 		"no-bitwise": "error",
 		"no-caller": "error",
-		"no-catch-shadow": "warn",
 		"no-compare-neg-zero": "error",
 		"no-confusing-arrow": "error",
 		"no-continue": "warn",
 		"no-div-regex": "error",
 		"no-duplicate-imports": "error",
-		"no-else-return": "error",
+		"no-else-return": [
+			"error",
+			{ "allowElseIf": false }
+		],
 		"no-empty": [
 			"error",
 			{ "allowEmptyCatch": true }
@@ -165,12 +157,11 @@ module.exports = {
 		"no-global-assign": "error",
 		"no-implicit-globals": "error",
 		"no-implied-eval": "error",
-		"no-inline-comments": "off",
 		"no-inner-declarations": [
 			"warn",
 			"both"
 		],
-		"no-invalid-this": "off",
+		"no-invalid-this": "warn",
 		"no-iterator": "error",
 		"no-label-var": "error",
 		"no-labels": "error",
@@ -205,9 +196,7 @@ module.exports = {
 		"no-new-require": "error",
 		"no-new-wrappers": "error",
 		"no-octal-escape": "error",
-		"no-param-reassign": "off",
 		"no-path-concat": "error",
-		"no-plusplus": "off",
 		"no-process-env": "error",
 		"no-process-exit": "error",
 		"no-proto": "error",
@@ -224,9 +213,7 @@ module.exports = {
 		"no-sequences": "error",
 		"no-shadow": "warn",
 		"no-shadow-restricted-names": "error",
-		"no-spaced-func": "error",
 		"no-sync": "warn",
-		"no-tabs": "off",
 		"no-template-curly-in-string": "error",
 		"no-ternary": "warn",
 		"no-throw-literal": "warn",
@@ -258,7 +245,7 @@ module.exports = {
 		"no-useless-escape": "error",
 		"no-useless-rename": "error",
 		"no-useless-return": "error",
-		"no-var": "off",
+		"no-var": "warn",
 		"no-void": "error",
 		"no-warning-comments": "warn",
 		"no-whitespace-before-property": "error",
@@ -283,22 +270,21 @@ module.exports = {
 			"warn",
 			"consistent"
 		],
-		"one-var": "off",
-		"one-var-declaration-per-line": "off",
 		"operator-assignment": [
 			"error",
 			"always"
 		],
 		"operator-linebreak": "error",
-		"padded-blocks": "off",
-		"prefer-arrow-callback": "off",
+		"padding-line-between-statements": [
+			"warn",
+			{ "blankLine": "always", "prev": ["const", "let", "var"], "next": "*"},
+			{ "blankLine": "any", "prev": ["const", "let", "var"], "next": ["const", "let", "var"]},
+			{ "blankLine": "always", "prev": "directive", "next": "*" },
+			{ "blankLine": "any", "prev": "directive", "next": "directive" },
+			{ "blankLine": "always", "prev": "*", "next": "return" }
+		],
 		"prefer-const": "error",
-		"prefer-destructuring": "off",
-		"prefer-numeric-literals": "off",
 		"prefer-promise-reject-errors": "error",
-		"prefer-rest-params": "off",
-		"prefer-spread": "off",
-		"prefer-template": "off",
 		"quote-props": [
 			"warn",
 			"consistent-as-needed"
@@ -313,15 +299,24 @@ module.exports = {
 		],
 		"radix": "error",
 		"require-await": "error",
-		"require-jsdoc": "off",
 		"rest-spread-spacing": "error",
-		"semi": "error",
+		"semi": [
+			"error",
+			"always"
+		],
 		"semi-spacing": "error",
 		"sort-imports": "error",
 		"sort-keys": "warn",
 		"sort-vars": "warn",
 		"space-before-blocks": "warn",
-		"space-before-function-paren": "off",
+		"space-before-function-paren": [
+			"warn",
+			{
+				"anonymous": "ignore",
+				"named": "never",
+				"asyncArrow": "ignore"
+			}
+		],
 		"space-in-parens": "warn",
 		"space-infix-ops": "error",
 		"space-unary-ops": "error",
@@ -340,14 +335,11 @@ module.exports = {
 			"warn",
 			"function"
 		],
-		"symbol-description": "off",
 		"template-curly-spacing": "error",
 		"template-tag-spacing": "error",
 		"unicode-bom": "error",
-		"valid-jsdoc": "warn",
 		"vars-on-top": "warn",
 		"wrap-iife": "error",
-		"wrap-regex": "off",
 		"yield-star-spacing": "error",
 		"yoda": "error"
 	}

.github/issue_template.md

@@ -0,0 +1,17 @@
+Please review [Instructions for Reporting a Bug](https://github.com/jquery-form/form/blob/master/CONTRIBUTING.md#reporting-a-bug).
+
+### Description:
+
+### Expected Behavior:
+
+### Actual behavior:
+
+### Versions:
+**LoadJSON:**   
+**jQuery:**   
+**Browsers:**   
+
+### Demonstration
+Link to demonstration of issue in [JSFiddle](https://jsfiddle.net/) or [CodePen](https://codepen.io/):
+
+### Steps to reproduce: