Skip to content

Commit 3e58608

Browse files
author
Javen
committed
Fix error code
1 parent 80b3f67 commit 3e58608

File tree

1 file changed

+42
-40
lines changed

1 file changed

+42
-40
lines changed

test/cn/jpush/api/push/remote/ExceptionTests.java

Lines changed: 42 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -206,44 +206,9 @@ public void invalidParams_notification_winphone_empty() {
206206
assertEquals(INVALID_PARAMS, result.getErrorCode());
207207
}
208208

209-
// ------------------------ lack of params
210-
211-
@Test
212-
public void lackOfParams_platform() {
213-
JsonObject payload = new JsonObject();
214-
payload.add("audience", Audience.all().toJSON());
215-
payload.add("notification", Notification.alert(ALERT).toJSON());
216-
System.out.println("json string: " + payload.toString());
217-
218-
PushResult result = _client.sendPush(payload.toString());
219-
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
220-
}
221-
222-
@Test
223-
public void lackOfParams_audience() {
224-
JsonObject payload = new JsonObject();
225-
payload.add("platform", Platform.all().toJSON());
226-
payload.add("notification", Notification.alert(ALERT).toJSON());
227-
System.out.println("json string: " + payload.toString());
228-
229-
PushResult result = _client.sendPush(payload.toString());
230-
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
231-
}
232209

233210
@Test
234-
public void lackOfParams_messageAndNotificaiton() {
235-
JsonObject payload = new JsonObject();
236-
payload.add("platform", Platform.all().toJSON());
237-
payload.add("audience", Audience.all().toJSON());
238-
System.out.println("json string: " + payload.toString());
239-
240-
PushResult result = _client.sendPush(payload.toString());
241-
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
242-
}
243-
244-
245-
@Test
246-
public void lackOfParams_notification_android_noalert() {
211+
public void invalidParams_notification_android_noalert() {
247212
JsonObject payload = new JsonObject();
248213
payload.add("platform", Platform.all().toJSON());
249214
payload.add("audience", Audience.all().toJSON());
@@ -258,11 +223,11 @@ public void lackOfParams_notification_android_noalert() {
258223
System.out.println("json string: " + payload.toString());
259224

260225
PushResult result = _client.sendPush(payload.toString());
261-
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
226+
assertEquals(INVALID_PARAMS, result.getErrorCode());
262227
}
263228

264229
@Test
265-
public void lackOfParams_notification_ios_noalert() {
230+
public void invalidParams_notification_ios_noalert() {
266231
JsonObject payload = new JsonObject();
267232
payload.add("platform", Platform.all().toJSON());
268233
payload.add("audience", Audience.all().toJSON());
@@ -277,11 +242,11 @@ public void lackOfParams_notification_ios_noalert() {
277242
System.out.println("json string: " + payload.toString());
278243

279244
PushResult result = _client.sendPush(payload.toString());
280-
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
245+
assertEquals(INVALID_PARAMS, result.getErrorCode());
281246
}
282247

283248
@Test
284-
public void lackOfParams_notification_winphone_noalert() {
249+
public void invalidParams_notification_winphone_noalert() {
285250
JsonObject payload = new JsonObject();
286251
payload.add("platform", Platform.all().toJSON());
287252
payload.add("audience", Audience.all().toJSON());
@@ -295,10 +260,47 @@ public void lackOfParams_notification_winphone_noalert() {
295260

296261
System.out.println("json string: " + payload.toString());
297262

263+
PushResult result = _client.sendPush(payload.toString());
264+
assertEquals(INVALID_PARAMS, result.getErrorCode());
265+
}
266+
267+
268+
// ------------------------ lack of params
269+
270+
@Test
271+
public void lackOfParams_platform() {
272+
JsonObject payload = new JsonObject();
273+
payload.add("audience", Audience.all().toJSON());
274+
payload.add("notification", Notification.alert(ALERT).toJSON());
275+
System.out.println("json string: " + payload.toString());
276+
277+
PushResult result = _client.sendPush(payload.toString());
278+
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
279+
}
280+
281+
@Test
282+
public void lackOfParams_audience() {
283+
JsonObject payload = new JsonObject();
284+
payload.add("platform", Platform.all().toJSON());
285+
payload.add("notification", Notification.alert(ALERT).toJSON());
286+
System.out.println("json string: " + payload.toString());
287+
298288
PushResult result = _client.sendPush(payload.toString());
299289
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
300290
}
301291

292+
@Test
293+
public void lackOfParams_messageAndNotificaiton() {
294+
JsonObject payload = new JsonObject();
295+
payload.add("platform", Platform.all().toJSON());
296+
payload.add("audience", Audience.all().toJSON());
297+
System.out.println("json string: " + payload.toString());
298+
299+
PushResult result = _client.sendPush(payload.toString());
300+
assertEquals(LACK_OF_PARAMS, result.getErrorCode());
301+
}
302+
303+
302304
@Test
303305
public void lackOfParams_message_noMsgContent() {
304306
JsonObject payload = new JsonObject();

0 commit comments

Comments
 (0)