minor #17872 [CS] PHPUnit dedicate assert fixer acceptance test (SpacePossum)

fabpot · fabpot · commit dbc514e27d27 · 2016-02-22T16:29:01.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- [CS] PHPUnit dedicate assert fixer acceptance test | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | License | MIT The goal of this PR is _not_ to have it merge, but to check with SF community if a new Fixer (PHP-CS-Fixer/PHP-CS-Fixer#1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer). Commits ------- fb141f2 PhpUnitNoDedicateAssertFixer results
diff --git a/Tests/Shell/CommandTest.php b/Tests/Shell/CommandTest.php
@@ -146,7 +146,7 @@ public function testExecute()
         $cmd->add('--version');
         $result = $cmd->execute();
 
-        $this->assertTrue(is_array($result));
+        $this->assertInternalType('array', $result);
         $this->assertNotEmpty($result);
         $this->assertRegexp('/PHP|HipHop/', $result[0]);
     }

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public function testExecute()`
`146`	`146`	`$cmd->add('--version');`
`147`	`147`	`$result = $cmd->execute();`
`148`	`148`
`149`		`- $this->assertTrue(is_array($result));`
	`149`	`+ $this->assertInternalType('array', $result);`
`150`	`150`	`$this->assertNotEmpty($result);`
`151`	`151`	`$this->assertRegexp('/PHP\|HipHop/', $result[0]);`
`152`	`152`	`}`