Python: Fix globals() == locals() FP

Author: RasmusWL

python/ql/src/Statements/ModificationOfLocals.ql

@@ -30,5 +30,11 @@ predicate modification_of_locals(ControlFlowNode f) {
 }
 
 from AstNode a, ControlFlowNode f
-where modification_of_locals(f) and a = f.getNode()
+where
+  modification_of_locals(f) and
+  a = f.getNode() and
+  // in module level scope `locals() == globals()`
+  // see https://docs.python.org/3/library/functions.html#locals
+  // FP report in https://github.com/github/codeql/issues/6674
+  not a.getScope() instanceof ModuleScope
 select a, "Modification of the locals() dictionary will have no effect on the local variables."

python/ql/test/query-tests/Statements/general/ModificationOfLocals.expected

@@ -3,4 +3,3 @@
 | test.py:101:5:101:14 | Attribute() | Modification of the locals() dictionary will have no effect on the local variables. |
 | test.py:102:9:102:14 | Subscript | Modification of the locals() dictionary will have no effect on the local variables. |
 | test.py:103:5:103:13 | Attribute() | Modification of the locals() dictionary will have no effect on the local variables. |
-| test.py:110:1:110:15 | Subscript | Modification of the locals() dictionary will have no effect on the local variables. |