Update to the TaintTracking::Global api

egregius313 · egregius313 · commit dcd703f1a932 · 2023-03-29T11:45:09.000-04:00
diff --git a/java/ql/lib/semmle/code/java/security/CommandLineQuery.qll b/java/ql/lib/semmle/code/java/security/CommandLineQuery.qll
@@ -52,7 +52,7 @@ module RemoteUserInputToArgumentToExecFlowConfig implements DataFlow::ConfigSig
 }
 
 module RemoteUserInputToArgumentToExecFlow =
-  TaintTracking::Make<RemoteUserInputToArgumentToExecFlowConfig>;
+  TaintTracking::Global<RemoteUserInputToArgumentToExecFlowConfig>;
 
 /**
  * Implementation of `ExecTainted.ql`. It is extracted to a QLL
@@ -63,6 +63,6 @@ predicate execTainted(
   RemoteUserInputToArgumentToExecFlow::PathNode source,
   RemoteUserInputToArgumentToExecFlow::PathNode sink, ArgumentToExec execArg
 ) {
-  RemoteUserInputToArgumentToExecFlow::hasFlowPath(source, sink) and
+  RemoteUserInputToArgumentToExecFlow::flowPath(source, sink) and
   sink.getNode() = DataFlow::exprNode(execArg)
 }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ module RemoteUserInputToArgumentToExecFlowConfig implements DataFlow::ConfigSig`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`module RemoteUserInputToArgumentToExecFlow =`
`55`		`- TaintTracking::Make<RemoteUserInputToArgumentToExecFlowConfig>;`
	`55`	`+ TaintTracking::Global<RemoteUserInputToArgumentToExecFlowConfig>;`
`56`	`56`
`57`	`57`	`/**`
`58`	`58`	* Implementation of `ExecTainted.ql`. It is extracted to a QLL
`@@ -63,6 +63,6 @@ predicate execTainted(`
`63`	`63`	`RemoteUserInputToArgumentToExecFlow::PathNode source,`
`64`	`64`	`RemoteUserInputToArgumentToExecFlow::PathNode sink, ArgumentToExec execArg`
`65`	`65`	`) {`
`66`		`- RemoteUserInputToArgumentToExecFlow::hasFlowPath(source, sink) and`
	`66`	`+ RemoteUserInputToArgumentToExecFlow::flowPath(source, sink) and`
`67`	`67`	`sink.getNode() = DataFlow::exprNode(execArg)`
`68`	`68`	`}`