Merge branch 'main' into visit-recursive-evaluation

Author: MathiasVP

ql/ql/src/codeql_ql/StructuredLogs.qll

@@ -241,6 +241,8 @@ module KindPredicatesLog {
 
     AppearsAs getAppearsAs() { result = this.getObject("appearsAs") }
 
+    int getMillis() { result = this.getNumber("millis") }
+
     predicate hasCompletionTime(
       int year, string month, int day, int hours, int minute, int second, int millisecond
     ) {
@@ -265,6 +267,12 @@ module KindPredicatesLog {
     Array getRA(string ordering) { result = this.getObject("ra").getArray(ordering) }
 
     string getAnOrdering() { exists(this.getRA(result)) }
+
+    override string toString() {
+      if exists(this.getPredicateName())
+      then result = this.getPredicateName()
+      else result = "<Summary event>"
+    }
   }
 
   class SentinelEmpty extends SummaryEvent {

ql/ql/src/experimental/queries/SlowPredicates.ql

@@ -0,0 +1,15 @@
+/**
+ * Shows a list of the "slow" predicates by wallclock time.
+ */
+
+import ql
+import codeql_ql.StructuredLogs
+
+int predicateRank(KindPredicatesLog::SummaryEvent evt) {
+  evt =
+    rank[result](KindPredicatesLog::SummaryEvent y, int m | m = y.getMillis() | y order by m desc)
+}
+
+from KindPredicatesLog::SummaryEvent evt
+where predicateRank(evt) < 50
+select evt, evt.getMillis() as time order by time desc

ql/ql/src/queries/performance/LargeJoinOrder.ql

@@ -0,0 +1,29 @@
+/**
+ * Shows a list of the non-recursive predicates with the worst join order as determined
+ * by the join order metric.
+ */
+
+import ql
+import codeql_ql.StructuredLogs
+import KindPredicatesLog
+
+/**
+ * Gets the badness of a non-recursive predicate evaluation.
+ *
+ * The badness is the maximum number of tuples in the pipeline divided by the
+ * maximum of two numbers: the size of the result and the size of the largest dependency.
+ */
+float getBadness(ComputeSimple simple) {
+  exists(float maxTupleCount, float resultSize, float largestDependency, float denom |
+    resultSize = simple.getResultSize() and
+    maxTupleCount = max(simple.getPipelineRun().getCount(_)) and
+    largestDependency = max(simple.getDependencies().getADependency().getResultSize()) and
+    denom = resultSize.maximum(largestDependency) and
+    denom > 0 and // avoid division by zero (which would create a NaN result).
+    result = maxTupleCount / denom
+  )
+}
+
+from ComputeSimple evt, float f
+where f = getBadness(evt) and f > 1.5
+select evt, f order by f desc