File tree Expand file tree Collapse file tree 1 file changed +11
-3
lines changed
python/ql/src/meta/alerts Expand file tree Collapse file tree 1 file changed +11
-3
lines changed Original file line number Diff line number Diff line change @@ -31,9 +31,17 @@ class RemoteFlowSourceReach extends TaintTracking::Configuration {
3131 or
3232 this .isAdditionalFlowStep ( _, node )
3333 ) and
34- // we used to do `obj -> obj.meth` and `obj.meth -> obj.meth()` in two separate
35- // steps, and now do them in one `obj -> obj.meth()`. So we're going to ignore the
36- // fact that we no longer taint the node in the middle.
34+ // In september 2021 we changed how we do taint-propagation for method calls (mostly
35+ // relating to modeled frameworks/libraries). We used to do `obj -> obj.meth` and
36+ // `obj.meth -> obj.meth()` in two separate steps, and now do them in one
37+ // `obj -> obj.meth()`. To be able to compare the overall reach between these two
38+ // version, we don't want this query to alert us to the fact that we no longer taint
39+ // the node in the middle (since that is just noise).
40+ // see https://github.com/github/codeql/pull/6349
41+ //
42+ // We should be able to remove the following few lines of code once we don't care to
43+ // compare with the old (before September 2021) way of doing taint-propagation for
44+ // method calls.
3745 not exists ( DataFlow:: MethodCallNode c |
3846 node = c .getFunction ( ) and
3947 this .isAdditionalFlowStep ( c .getObject ( ) , node ) and
You can’t perform that action at this time.
0 commit comments