Update javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll

erik-krogh · asgerf · web-flow · commit bdab57b9d3aa · 2023-03-22T10:19:48.000+01:00
Co-authored-by: Asger F &lt;asgerf@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
@@ -381,7 +381,7 @@ module AccessPath {
         result.getImmediateDominator() = writeNode.getBasicBlock()
       )
       or
-      result.getImmediateDominator() = getASuccessorBBThatReadsVar(write) // more manual magic - outlined into a helper predicate.
+      result.getImmediateDominator() = getASuccessorBBThatReadsVar(write)
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -381,7 +381,7 @@ module AccessPath {`
`381`	`381`	`result.getImmediateDominator() = writeNode.getBasicBlock()`
`382`	`382`	`)`
`383`	`383`	`or`
`384`		`- result.getImmediateDominator() = getASuccessorBBThatReadsVar(write) // more manual magic - outlined into a helper predicate.`
	`384`	`+ result.getImmediateDominator() = getASuccessorBBThatReadsVar(write)`
`385`	`385`	`}`
`386`	`386`	`}`
`387`	`387`