Merge pull request github#11767 from atorralba/atorralba/java/fix-pinning-tests

Java: Small simplification in Missing Certificate Pinning tests

Author: egregius313

java/ql/test/query-tests/security/CWE-295/AndroidMissingCertificatePinning/Test2/test.ql

@@ -13,11 +13,7 @@ class Test extends InlineExpectationsTest {
       loc = node.getLocation() and
       el = node.toString() and
       value = "" and
-      (
-        if exists(string x | trustedDomain(x))
-        then tag = "hasUntrustedResult"
-        else tag = "hasNoTrustedResult"
-      )
+      if trustedDomain(_) then tag = "hasUntrustedResult" else tag = "hasNoTrustedResult"
     )
   }
 }

java/ql/test/query-tests/security/CWE-295/AndroidMissingCertificatePinning/Test3/test.ql

@@ -13,11 +13,7 @@ class Test extends InlineExpectationsTest {
       loc = node.getLocation() and
       el = node.toString() and
       value = "" and
-      (
-        if exists(string x | trustedDomain(x))
-        then tag = "hasUntrustedResult"
-        else tag = "hasNoTrustedResult"
-      )
+      if trustedDomain(_) then tag = "hasUntrustedResult" else tag = "hasNoTrustedResult"
     )
   }
 }

java/ql/test/query-tests/security/CWE-295/AndroidMissingCertificatePinning/Test4/test.ql

@@ -13,11 +13,7 @@ class Test extends InlineExpectationsTest {
       loc = node.getLocation() and
       el = node.toString() and
       value = "" and
-      (
-        if exists(string x | trustedDomain(x))
-        then tag = "hasUntrustedResult"
-        else tag = "hasNoTrustedResult"
-      )
+      if trustedDomain(_) then tag = "hasUntrustedResult" else tag = "hasNoTrustedResult"
     )
   }
 }

java/ql/test/query-tests/security/CWE-295/AndroidMissingCertificatePinning/Test5/test.ql

@@ -13,11 +13,7 @@ class Test extends InlineExpectationsTest {
       loc = node.getLocation() and
       el = node.toString() and
       value = "" and
-      (
-        if exists(string x | trustedDomain(x))
-        then tag = "hasUntrustedResult"
-        else tag = "hasNoTrustedResult"
-      )
+      if trustedDomain(_) then tag = "hasUntrustedResult" else tag = "hasNoTrustedResult"
     )
   }
 }