Swift: Move append methods into RangeReplaceableCollection.

Author: geoffw0

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Collection.qll

@@ -25,6 +25,8 @@ private class CollectionSummaries extends SummaryModelCsv {
         ";Collection;true;split(maxSplits:omittingEmptySubsequences:whereSeparator:);;;Argument[-1];ReturnValue;taint",
         ";Collection;true;split(separator:maxSplits:omittingEmptySubsequences:);;;Argument[-1];ReturnValue;taint",
         ";Collection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
+        ";RangeReplaceableCollection;true;append(_:);;;Argument[0];Argument[-1];taint",
+        ";RangeReplaceableCollection;true;append(contentsOf:);;;Argument[0];Argument[-1];taint",
         ";RangeReplaceableCollection;true;remove(at:);;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Data.qll

@@ -22,9 +22,7 @@ private class DataSummaries extends SummaryModelCsv {
         ";Data;true;init(contentsOf:options:);;;Argument[0];ReturnValue;taint",
         ";Data;true;init(bytesNoCopy:count:deallocator:);;;Argument[0];ReturnValue;taint",
         ";Data;true;init(referencing:);;;Argument[0];ReturnValue;taint",
-        ";Data;true;append(_:);;;Argument[0];Argument[-1];taint",
         ";Data;true;append(_:count:);;;Argument[0];Argument[-1];taint",
-        ";Data;true;append(contentsOf:);;;Argument[0];Argument[-1];taint",
         ";Data;true;base64EncodedData(options:);;;Argument[-1];ReturnValue;taint",
         ";Data;true;base64EncodedString(options:);;;Argument[-1];ReturnValue;taint",
         ";Data;true;compactMap(_:);;;Argument[-1];ReturnValue;taint",

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/String.qll

@@ -100,8 +100,6 @@ private class StringSummaries extends SummaryModelCsv {
         ";String;true;localizedStringWithFormat(_:_:);;;Argument[0..1];ReturnValue;taint",
         ";String;true;write(_:);;;Argument[0];Argument[-1];taint",
         ";String;true;write(to:);;;Argument[-1];Argument[0];taint",
-        ";String;true;append(_:);;;Argument[0];Argument[-1];taint",
-        ";String;true;append(contentsOf:);;;Argument[0];Argument[-1];taint",
         ";String;true;insert(_:at:);;;Argument[0];Argument[-1];taint",
         ";String;true;insert(contentsOf:at:);;;Argument[0];Argument[-1];taint",
         ";String;true;replaceSubrange(_:with::);;;Argument[1];Argument[-1];taint",