Use readble format for APIs

Author: Benjamin Muskalla

java/ql/src/Telemetry/ExternalAPI.qll

@@ -16,10 +16,10 @@ class ExternalAPI extends Callable {
   /**
    * Gets information about the external API in the form expected by the CSV modeling framework.
    */
-  string asCsv(ExternalAPI api) {
+  string asHumanReadbleString(ExternalAPI api) {
     result =
-      api.getDeclaringType().getPackage() + ";?;" + api.getDeclaringType().getSourceDeclaration() +
-        ";" + api.getName() + ";" + paramsString(api)
+      api.getDeclaringType().getPackage() + "." + api.getDeclaringType().getSourceDeclaration() +
+        "#" + api.getName() + paramsString(api)
   }
 
   /** Holds if this API is not yet supported by existing CodeQL libraries */

java/ql/src/Telemetry/SupportedExternalSinks.ql

@@ -20,4 +20,4 @@ where
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
-select api.asCsv(api) as csv, usages order by usages desc
+select api.asHumanReadbleString(api) as apiname, usages order by usages desc

java/ql/src/Telemetry/SupportedExternalSources.ql

@@ -20,4 +20,4 @@ where
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
-select api.asCsv(api) as csv, usages order by usages desc
+select api.asHumanReadbleString(api) as apiname, usages order by usages desc

java/ql/src/Telemetry/SupportedExternalTaint.ql

@@ -20,4 +20,4 @@ where
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
-select api.asCsv(api) as csv, usages order by usages desc
+select api.asHumanReadbleString(api) as apiname, usages order by usages desc

java/ql/src/Telemetry/UnsupportedExternalAPIs.ql

@@ -20,4 +20,4 @@ where
       c.getCallee().getSourceDeclaration() = api and
       not c.getFile() instanceof GeneratedFile
     )
-select api.asCsv(api) as csv, usages order by usages desc
+select api.asHumanReadbleString(api) as apiname, usages order by usages desc

java/ql/test/query-tests/Telemetry/SupportedExternalSinks/SupportedExternalSinks.expected

@@ -1,2 +1,2 @@
-| java.io;?;FileWriter;FileWriter;(File) | 1 |
-| java.net;?;URL;openStream;() | 1 |
+| java.io.FileWriter#FileWriter(File) | 1 |
+| java.net.URL#openStream() | 1 |

java/ql/test/query-tests/Telemetry/SupportedExternalSources/SupportedExternalSources.expected

@@ -1 +1 @@
-| java.net;?;URLConnection;getInputStream;() | 1 |
+| java.net.URLConnection#getInputStream() | 1 |

java/ql/test/query-tests/Telemetry/SupportedExternalTaint/SupportedExternalTaint.expected

@@ -1,2 +1,2 @@
-| java.lang;?;StringBuilder;append;(String) | 1 |
-| java.lang;?;StringBuilder;toString;() | 1 |
+| java.lang.StringBuilder#append(String) | 1 |
+| java.lang.StringBuilder#toString() | 1 |

java/ql/test/query-tests/Telemetry/UnsupportedExternalAPIs/UnsupportedExternalAPIs.expected

@@ -1,4 +1,4 @@
-| java.io;?;PrintStream;println;(Object) | 3 |
-| java.lang;?;Object;Object;() | 2 |
-| java.lang;?;String;length;() | 1 |
-| java.time;?;Duration;ofMillis;(long) | 1 |
+| java.io.PrintStream#println(Object) | 3 |
+| java.lang.Object#Object() | 2 |
+| java.lang.String#length() | 1 |
+| java.time.Duration#ofMillis(long) | 1 |