DataFlow: Remove bindingsets, remove the call column, and swap parameter and argument columns.

Author: MathiasVP

cpp/ql/lib/experimental/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll

@@ -571,13 +571,6 @@ private class MyConsistencyConfiguration extends Consistency::ConsistencyConfigu
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll

@@ -324,13 +324,6 @@ private class MyConsistencyConfiguration extends Consistency::ConsistencyConfigu
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll

@@ -420,13 +420,6 @@ private class MyConsistencyConfiguration extends Consistency::ConsistencyConfigu
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll

@@ -2380,13 +2380,6 @@ module Csv {
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll

@@ -396,13 +396,6 @@ ContentApprox getContentApprox(Content c) { any() }
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll

@@ -484,13 +484,6 @@ predicate containerContent(Content c) {
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

@@ -1014,13 +1014,6 @@ ContentApprox getContentApprox(Content c) { any() }
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll

@@ -1504,13 +1504,6 @@ class AdditionalJumpStep extends Unit {
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll

@@ -702,13 +702,6 @@ ContentApprox getContentApprox(Content c) { any() }
  * an additional forward or backwards branching factor that is not taken into account
  * when calculating the (virtual) dispatch cost.
  *
- * `call` is a call with an argument `arg` that is part of a path from a source to a sink, and
- * `p` is the target parameter of a callable to which `call` may resolve.
- *
- * All these values are bound by the dataflow library, and if this predicate is implemented it
- * should be specified with a bindingset annotation that binds all the columns.
+ * Argument `arg` is part of a path from a source to a sink, and `p` is the target parameter.
  */
-bindingset[call, p, arg]
-int getAdditionalFlowIntoCallNodeTerm(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
-  none()
-}
+int getAdditionalFlowIntoCallNodeTerm(ArgumentNode arg, ParameterNode p) { none() }