Merge pull request github#12169 from hvitved/util/numbers

Move `NumberUtils.qll` from Ruby into shared `util` pack

Author: hvitved

ruby/ql/lib/codeql/ruby/ast/internal/Literal.qll

@@ -4,7 +4,7 @@ private import Constant
 private import TreeSitter
 private import codeql.ruby.ast.internal.Scope
 private import codeql.ruby.controlflow.CfgNodes
-private import codeql.NumberUtils
+private import codeql.util.Numbers
 
 int parseInteger(Ruby::Integer i) {
   exists(string s | s = i.getValue().toLowerCase().replaceAll("_", "") |

ruby/ql/lib/codeql/ruby/regexp/RegExpTreeView.qll

@@ -1,7 +1,7 @@
 /** Provides a class hierarchy corresponding to a parse tree of regular expressions. */
 
 private import internal.ParseRegExp
-private import codeql.NumberUtils
+private import codeql.util.Numbers
 private import codeql.ruby.ast.Literal as Ast
 private import codeql.Locations
 private import codeql.regex.nfa.NfaUtils as NfaUtils

ruby/ql/lib/qlpack.yml

@@ -9,5 +9,6 @@ dependencies:
   codeql/regex: ${workspace}
   codeql/ssa: ${workspace}
   codeql/tutorial: ${workspace}
+  codeql/util: ${workspace}
 dataExtensions:
   - codeql/ruby/frameworks/**/model.yml

ruby/ql/lib/codeql/NumberUtils.qll renamed to shared/util/codeql/util/Numbers.qll

@@ -104,7 +104,7 @@ private int toHex(string hex) {
  * Gets the value of 16 to the power of `n`. Holds only for `n` in the range
  * 0..7 (inclusive).
  */
-int sixteenToThe(int n) {
+private int sixteenToThe(int n) {
   // 16**7 is the largest power of 16 that fits in an int.
   n in [0 .. 7] and result = 1.bitShiftLeft(4 * n)
 }
@@ -113,7 +113,7 @@ int sixteenToThe(int n) {
  * Gets the value of 8 to the power of `n`. Holds only for `n` in the range
  * 0..10 (inclusive).
  */
-int eightToThe(int n) {
+private int eightToThe(int n) {
   // 8**10 is the largest power of 8 that fits in an int.
   n in [0 .. 10] and result = 1.bitShiftLeft(3 * n)
 }
@@ -122,7 +122,7 @@ int eightToThe(int n) {
  * Gets the value of 2 to the power of `n`. Holds only for `n` in the range
  * 0..30 (inclusive).
  */
-int twoToThe(int n) { n in [0 .. 30] and result = 1.bitShiftLeft(n) }
+private int twoToThe(int n) { n in [0 .. 30] and result = 1.bitShiftLeft(n) }
 
 /** Gets `s` with any leading "0" characters removed. */
 bindingset[s]