Ruby: lower severity of parse error to warning

Author: aibaars

ruby/extractor/src/extractor.rs

@@ -294,7 +294,7 @@ impl<'a> Visitor<'a> {
             .diagnostics_writer
             .new_entry("parse-error", "Parse error");
         &mesg
-            .severity(diagnostics::Severity::Error)
+            .severity(diagnostics::Severity::Warning)
             .location(self.path, start_line, start_column, end_line, end_column)
             .message(message, args);
         if status_page {
@@ -405,7 +405,7 @@ impl<'a> Visitor<'a> {
                     loc,
                     self.diagnostics_writer
                         .new_entry("parse-error", "Parse error")
-                        .severity(diagnostics::Severity::Error)
+                        .severity(diagnostics::Severity::Warning)
                         .location(self.path, start_line, start_column, end_line, end_column)
                         .message(
                             "Unknown table type: {}",

ruby/ql/integration-tests/all-platforms/diagnostics/syntax-error/diagnostics.expected

@@ -11,7 +11,7 @@
   },
   "markdownMessage": "A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or [exclude](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning) the file from analysis.",
   "plaintextMessage": "A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.",
-  "severity": "Error",
+  "severity": "Warning",
   "source": {
     "extractorName": "ruby",
     "id": "ruby/parse-error",
@@ -34,7 +34,7 @@
   },
   "markdownMessage": "A parse error occurred (expected `end` symbol). Check the syntax of the file. If the file is invalid, correct the error or [exclude](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning) the file from analysis.",
   "plaintextMessage": "A parse error occurred (expected end symbol). Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.",
-  "severity": "Error",
+  "severity": "Warning",
   "source": {
     "extractorName": "ruby",
     "id": "ruby/parse-error",

ruby/ql/lib/change-notes/2023-03-09-parse-error.md

@@ -0,0 +1,4 @@
+---
+ category: minorAnalysis
+---
+* The severity of parse errors was reduced to warning (previously error). 

ruby/ql/lib/codeql/ruby/Diagnostics.qll

@@ -47,6 +47,6 @@ class Diagnostic extends @diagnostic {
 }
 
 /** A diagnostic relating to a particular error in extracting a file. */
-class ExtractionError extends Diagnostic, @diagnostic_error {
+class ExtractionError extends Diagnostic {
   ExtractionError() { this.getTag() = "parse_error" }
 }