Swift: Move popLast to BidirectionalCollection and add popFirst.

Author: geoffw0

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Collection.qll

@@ -25,13 +25,15 @@ private class CollectionSummaries extends SummaryModelCsv {
         ";Collection;true;split(maxSplits:omittingEmptySubsequences:whereSeparator:);;;Argument[-1];ReturnValue;taint",
         ";Collection;true;split(separator:maxSplits:omittingEmptySubsequences:);;;Argument[-1];ReturnValue;taint",
         ";Collection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
+        ";Collection;true;popFirst();;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;append(_:);;;Argument[0];Argument[-1];taint",
         ";RangeReplaceableCollection;true;append(contentsOf:);;;Argument[0];Argument[-1];taint",
         ";RangeReplaceableCollection;true;remove(at:);;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;removeFirst();;;Argument[-1];ReturnValue;taint",
         ";RangeReplaceableCollection;true;removeLast();;;Argument[-1];ReturnValue;taint",
         ";BidirectionalCollection;true;joined(separator:);;;Argument[-1..0];ReturnValue;taint",
         ";BidirectionalCollection;true;last(where:);;;Argument[-1];ReturnValue;taint",
+        ";BidirectionalCollection;true;popLast();;;Argument[-1];ReturnValue;taint",
       ]
   }
 }

swift/ql/lib/codeql/swift/frameworks/StandardLibrary/String.qll

@@ -103,7 +103,6 @@ private class StringSummaries extends SummaryModelCsv {
         ";String;true;insert(_:at:);;;Argument[0];Argument[-1];taint",
         ";String;true;insert(contentsOf:at:);;;Argument[0];Argument[-1];taint",
         ";String;true;replaceSubrange(_:with::);;;Argument[1];Argument[-1];taint",
-        ";String;true;popLast();;;Argument[-1];ReturnValue;taint",
         ";String;true;max();;;Argument[-1];ReturnValue;taint",
         ";String;true;max(by:);;;Argument[-1];ReturnValue;taint",
         ";String;true;min();;;Argument[-1];ReturnValue;taint",