Added check to disabling certificate validation query

ctbellanti · ctbellanti · commit 6bf94e800be5 · 2023-03-27T12:16:20.000-04:00
diff --git a/javascript/ql/src/Security/CWE-295/DisablingCertificateValidation.ql b/javascript/ql/src/Security/CWE-295/DisablingCertificateValidation.ql
@@ -19,6 +19,8 @@ DataFlow::InvokeNode tlsInvocation() {
   or
   result = DataFlow::moduleMember("https", "Agent").getAnInstantiation()
   or
+  result = DataFlow::moduleMember("https", "createServer").getACall()
+  or
   exists(DataFlow::NewNode new |
     new = DataFlow::moduleMember("tls", "TLSSocket").getAnInstantiation()
   |
diff --git a/javascript/ql/src/change-notes/2023-03-27-disabling-certificate-validation.md b/javascript/ql/src/change-notes/2023-03-27-disabling-certificate-validation.md
@@ -0,0 +1,4 @@
+---
+category: majorAnalysis
+---
+* The `DisablingCertificateValidation.ql` query has been updated to check `createServer` from `https` for disabled certificate validation.

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ DataFlow::InvokeNode tlsInvocation() {`
`19`	`19`	`or`
`20`	`20`	`result = DataFlow::moduleMember("https", "Agent").getAnInstantiation()`
`21`	`21`	`or`
	`22`	`+ result = DataFlow::moduleMember("https", "createServer").getACall()`
	`23`	`+ or`
`22`	`24`	`exists(DataFlow::NewNode new \|`
`23`	`25`	`new = DataFlow::moduleMember("tls", "TLSSocket").getAnInstantiation()`
`24`	`26`	`\|`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: majorAnalysis
 +---
 +* The `DisablingCertificateValidation.ql` query has been updated to check `createServer` from `https` for disabled certificate validation.