Skip to content

Commit 64fb98e

Browse files
geoffw0geoffw0
committed
Swift: Rewrite bits to try and get rid of red highlighting.
1 parent 1724473 commit 64fb98e

File tree

2 files changed

+34
-32
lines changed

2 files changed

+34
-32
lines changed

‎swift/ql/test/library-tests/dataflow/flowsources/FlowSources.expected‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
| alamofire.swift:91:27:91:27 | .result | external |
22
| alamofire.swift:99:27:99:27 | .result | external |
3-
| alamofire.swift:342:23:342:32 | .data | external |
4-
| alamofire.swift:349:22:349:31 | .value | external |
5-
| alamofire.swift:356:23:356:32 | .value | external |
6-
| alamofire.swift:363:22:363:31 | .value | external |
7-
| alamofire.swift:370:23:370:32 | .value | external |
8-
| alamofire.swift:377:28:377:37 | .value | external |
9-
| alamofire.swift:387:28:387:28 | call to init(contentsOfFile:) | external |
10-
| alamofire.swift:387:28:387:55 | call to init(contentsOfFile:) | external |
11-
| alamofire.swift:394:22:394:31 | .value | external |
12-
| alamofire.swift:401:22:401:31 | .value | external |
13-
| alamofire.swift:402:28:402:28 | call to init(contentsOf:) | external |
14-
| alamofire.swift:402:28:402:50 | call to init(contentsOf:) | external |
15-
| alamofire.swift:409:23:409:32 | .value | external |
16-
| alamofire.swift:416:22:416:31 | .value | external |
17-
| alamofire.swift:423:23:423:32 | .value | external |
18-
| alamofire.swift:429:28:429:37 | .value | external |
19-
| alamofire.swift:446:20:446:20 | call to init(contentsOfFile:) | external |
20-
| alamofire.swift:446:20:446:49 | call to init(contentsOfFile:) | external |
21-
| alamofire.swift:453:23:453:32 | .data | external |
22-
| alamofire.swift:459:23:459:32 | .data | external |
3+
| alamofire.swift:344:23:344:32 | .data | external |
4+
| alamofire.swift:351:22:351:31 | .value | external |
5+
| alamofire.swift:358:23:358:32 | .value | external |
6+
| alamofire.swift:365:22:365:31 | .value | external |
7+
| alamofire.swift:372:23:372:32 | .value | external |
8+
| alamofire.swift:379:28:379:37 | .value | external |
9+
| alamofire.swift:389:28:389:28 | call to init(contentsOfFile:) | external |
10+
| alamofire.swift:389:28:389:55 | call to init(contentsOfFile:) | external |
11+
| alamofire.swift:396:22:396:31 | .value | external |
12+
| alamofire.swift:403:22:403:31 | .value | external |
13+
| alamofire.swift:404:28:404:28 | call to init(contentsOf:) | external |
14+
| alamofire.swift:404:28:404:50 | call to init(contentsOf:) | external |
15+
| alamofire.swift:411:23:411:32 | .value | external |
16+
| alamofire.swift:418:22:418:31 | .value | external |
17+
| alamofire.swift:425:23:425:32 | .value | external |
18+
| alamofire.swift:431:28:431:37 | .value | external |
19+
| alamofire.swift:448:20:448:20 | call to init(contentsOfFile:) | external |
20+
| alamofire.swift:448:20:448:49 | call to init(contentsOfFile:) | external |
21+
| alamofire.swift:455:23:455:32 | .data | external |
22+
| alamofire.swift:461:23:461:32 | .data | external |
2323
| customurlschemes.swift:30:44:30:54 | url | external |
2424
| customurlschemes.swift:34:52:34:68 | url | external |
2525
| customurlschemes.swift:38:52:38:62 | url | external |

‎swift/ql/test/library-tests/dataflow/flowsources/alamofire.swift‎

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,9 @@ struct MyStreamSerializer: DataStreamSerializer {
332332
struct MyDecodable: Decodable {
333333
}
334334

335-
func doSomething(_ p: Any) {}
335+
func doSomethingWith(_ param: Any) {
336+
// ...
337+
}
336338

337339
func testAlamofire() {
338340
// requests
@@ -469,11 +471,11 @@ func testAlamofire() {
469471
case let .stream(result):
470472
switch result {
471473
case let .success(data): // SOURCE [NOT DETECTED]
472-
doSomething(data)
474+
doSomethingWith(data)
473475
// ...
474476
}
475477
case let .complete(completion):
476-
doSomething(completion)
478+
doSomethingWith(completion)
477479
// ...
478480
}
479481
}
@@ -484,11 +486,11 @@ func testAlamofire() {
484486
case let .stream(result):
485487
switch result {
486488
case let .success(value): // SOURCE [NOT DETECTED]
487-
doSomething(value)
489+
doSomethingWith(value)
488490
// ...
489491
}
490492
case let .complete(completion):
491-
doSomething(completion)
493+
doSomethingWith(completion)
492494
// ...
493495
}
494496
}
@@ -499,11 +501,11 @@ func testAlamofire() {
499501
case let .stream(result):
500502
switch result {
501503
case let .success(value): // SOURCE [NOT DETECTED]
502-
doSomething(value)
504+
doSomethingWith(value)
503505
// ...
504506
}
505507
case let .complete(completion):
506-
doSomething(completion)
508+
doSomethingWith(completion)
507509
// ...
508510
}
509511
}
@@ -514,11 +516,11 @@ func testAlamofire() {
514516
case let .stream(result):
515517
switch result {
516518
case let .success(value): // SOURCE [NOT DETECTED]
517-
doSomething(value)
519+
doSomethingWith(value)
518520
// ...
519521
}
520522
case let .complete(completion):
521-
doSomething(completion)
523+
doSomethingWith(completion)
522524
// ...
523525
}
524526
}
@@ -529,15 +531,15 @@ func testAlamofire() {
529531
stream in
530532
if case let .stream(myResult) = stream.event {
531533
if case let .success(myData) = myResult { // SOURCE [NOT DETECTED]
532-
doSomething(myData)
534+
doSomethingWith(myData)
533535
}
534536
}
535537
}
536538

537539
AF.streamRequest("http://example.com/").responseStream {
538540
stream in
539541
if case let .stream(myResult) = stream.event {
540-
doSomething(myResult.success!) // SOURCE [NOT DETECTED]
542+
doSomethingWith(myResult.success!) // SOURCE [NOT DETECTED]
541543
}
542544
}
543545

@@ -546,6 +548,6 @@ func testAlamofire() {
546548
let myResult = Result<String, Error>.success("data")
547549

548550
if case let .success(myString) = myResult {
549-
doSomething(myString)
551+
doSomethingWith(myString)
550552
}
551553
}

0 commit comments

Comments
 (0)