C#: Actually add the deprecated keyword to the deprecated classes.

michaelnebel · michaelnebel · commit 31e352afb03d · 2023-03-30T09:45:49.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/security/cryptography/HardcodedSymmetricEncryptionKey.qll b/csharp/ql/lib/semmle/code/csharp/security/cryptography/HardcodedSymmetricEncryptionKey.qll
@@ -66,7 +66,7 @@ module HardcodedSymmetricEncryptionKey {
    *
    * A taint-tracking configuration for uncontrolled data in path expression vulnerabilities.
    */
-  class TaintTrackingConfiguration extends TaintTracking::Configuration {
+  deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {
     TaintTrackingConfiguration() { this = "HardcodedSymmetricEncryptionKey" }
 
     override predicate isSource(DataFlow::Node source) { source instanceof Source }
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/CodeInjectionQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/CodeInjectionQuery.qll
@@ -29,7 +29,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }
  *
  * A taint-tracking configuration for user input treated as code vulnerabilities.
  */
-class TaintTrackingConfiguration extends TaintTracking::Configuration {
+deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {
   TaintTrackingConfiguration() { this = "CodeInjection" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof Source }
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/CommandInjectionQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/CommandInjectionQuery.qll
@@ -27,7 +27,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }
  *
  * A taint-tracking configuration for command injection vulnerabilities.
  */
-class TaintTrackingConfiguration extends TaintTracking::Configuration {
+deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {
   TaintTrackingConfiguration() { this = "CommandInjection" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof Source }
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/ConditionalBypassQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/ConditionalBypassQuery.qll
@@ -34,7 +34,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }
  *
  * A taint-tracking configuration for user-controlled bypass of sensitive method.
  */
-class Configuration extends TaintTracking::Configuration {
+deprecated class Configuration extends TaintTracking::Configuration {
   Configuration() { this = "UserControlledBypassOfSensitiveMethodConfiguration" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof Source }
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExposureOfPrivateInformationQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExposureOfPrivateInformationQuery.qll
@@ -27,7 +27,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }
  *
  * A taint-tracking configuration for private information flowing unencrypted to an external location.
  */
-class TaintTrackingConfiguration extends TaintTracking::Configuration {
+deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {
   TaintTrackingConfiguration() { this = "ExposureOfPrivateInformation" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof Source }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ module HardcodedSymmetricEncryptionKey {`
`66`	`66`	`*`
`67`	`67`	`* A taint-tracking configuration for uncontrolled data in path expression vulnerabilities.`
`68`	`68`	`*/`
`69`		`- class TaintTrackingConfiguration extends TaintTracking::Configuration {`
	`69`	`+ deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {`
`70`	`70`	`TaintTrackingConfiguration() { this = "HardcodedSymmetricEncryptionKey" }`
`71`	`71`
`72`	`72`	`override predicate isSource(DataFlow::Node source) { source instanceof Source }`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }`
`29`	`29`	`*`
`30`	`30`	`* A taint-tracking configuration for user input treated as code vulnerabilities.`
`31`	`31`	`*/`
`32`		`-class TaintTrackingConfiguration extends TaintTracking::Configuration {`
	`32`	`+deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {`
`33`	`33`	`TaintTrackingConfiguration() { this = "CodeInjection" }`
`34`	`34`
`35`	`35`	`override predicate isSource(DataFlow::Node source) { source instanceof Source }`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }`
`27`	`27`	`*`
`28`	`28`	`* A taint-tracking configuration for command injection vulnerabilities.`
`29`	`29`	`*/`
`30`		`-class TaintTrackingConfiguration extends TaintTracking::Configuration {`
	`30`	`+deprecated class TaintTrackingConfiguration extends TaintTracking::Configuration {`
`31`	`31`	`TaintTrackingConfiguration() { this = "CommandInjection" }`
`32`	`32`
`33`	`33`	`override predicate isSource(DataFlow::Node source) { source instanceof Source }`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ abstract class Sanitizer extends DataFlow::ExprNode { }`
`34`	`34`	`*`
`35`	`35`	`* A taint-tracking configuration for user-controlled bypass of sensitive method.`
`36`	`36`	`*/`
`37`		`-class Configuration extends TaintTracking::Configuration {`
	`37`	`+deprecated class Configuration extends TaintTracking::Configuration {`
`38`	`38`	`Configuration() { this = "UserControlledBypassOfSensitiveMethodConfiguration" }`
`39`	`39`
`40`	`40`	`override predicate isSource(DataFlow::Node source) { source instanceof Source }`