Merge pull request github#6486 from ihsinme/ihsinme-patch-textFix

MathiasVP · web-flow · commit 221a25993854 · 2021-08-16T14:49:33.000+02:00
correction of the error text
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-758/UndefinedOrImplementationDefinedBehavior.ql b/cpp/ql/src/experimental/Security/CWE/CWE-758/UndefinedOrImplementationDefinedBehavior.ql
@@ -163,4 +163,5 @@ where
     or
     eots.dangerousCrementChanges()
   )
-select eots, "This expression may have undefined behavior."
+select eots,
+  "This expression may have undefined behavior, because the order of evaluation is not specified."
diff --git a/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-758/semmle/tests/UndefinedOrImplementationDefinedBehavior.expected b/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-758/semmle/tests/UndefinedOrImplementationDefinedBehavior.expected
@@ -1,3 +1,3 @@
-| test.c:13:10:13:21 | call to tmpFunction1 | This expression may have undefined behavior. |
-| test.c:13:30:13:41 | call to tmpFunction2 | This expression may have undefined behavior. |
-| test.c:16:15:16:20 | ... ++ | This expression may have undefined behavior. |
+| test.c:13:10:13:21 | call to tmpFunction1 | This expression may have undefined behavior, because the order of evaluation is not specified. |
+| test.c:13:30:13:41 | call to tmpFunction2 | This expression may have undefined behavior, because the order of evaluation is not specified. |
+| test.c:16:15:16:20 | ... ++ | This expression may have undefined behavior, because the order of evaluation is not specified. |

Original file line number	Diff line number	Diff line change
`@@ -163,4 +163,5 @@ where`
`163`	`163`	`or`
`164`	`164`	`eots.dangerousCrementChanges()`
`165`	`165`	`)`
`166`		`-select eots, "This expression may have undefined behavior."`
	`166`	`+select eots,`
	`167`	`+ "This expression may have undefined behavior, because the order of evaluation is not specified."`